Fixed a numerical issue leading to an infinite loop on some compilers

KLayout · Jan 23, 2024 · 6ad1f3f · 6ad1f3f
1 parent cb3d7bc
commit 6ad1f3f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/db/db/dbTriangles.cc b/src/db/db/dbTriangles.cc
@@ -491,7 +491,7 @@ Triangles::find_closest_edge (const db::DPoint &p, db::Vertex *vstart, bool insi
           db::DVector r = p - *cv;
           double edge_sp = db::sprod (r, edge_d) / edge_d.length ();
           double s_sp = db::sprod (r, e_d) / e_d.length ();
-          if (s_sp > edge_sp) {
+          if (s_sp > edge_sp + db::epsilon) {
             edge = *e;
             vnext = edge->other (v);
           }

diff --git a/src/db/unit_tests/dbTrianglesTests.cc b/src/db/unit_tests/dbTrianglesTests.cc
@@ -126,7 +126,7 @@ TEST(insert_vertex_convex)
   tris.insert_point (0.6, 0.5);
   tris.insert_point (0.7, 0.5);
   tris.insert_point (0.6, 0.4);
-  EXPECT_EQ (tris.to_string (), "((0.2, 0.2), (0.2, 0.8), (0.6, 0.5)), ((0.7, 0.5), (0.6, 0.5), (0.2, 0.8)), ((0.6, 0.5), (0.6, 0.4), (0.2, 0.2)), ((0.6, 0.5), (0.7, 0.5), (0.6, 0.4))");
+  EXPECT_EQ (tris.to_string (), "((0.2, 0.2), (0.2, 0.8), (0.6, 0.5)), ((0.2, 0.8), (0.7, 0.5), (0.6, 0.5)), ((0.6, 0.4), (0.6, 0.5), (0.7, 0.5)), ((0.6, 0.4), (0.2, 0.2), (0.6, 0.5))");
   EXPECT_EQ (tris.check(), true);
 }