Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements CRequest #353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Small improvements CRequest #353

wants to merge 1 commit into from

Conversation

belentorrente
Copy link
Collaborator

Tried to reduce de cyclomatic complexity of CRequest (removing nested ifs where possible), also moving some code around to avoid redundancy. Tried to return as soon as possible instead of keeping the algorithm going with conditions that evaluate to false over and over.
Some variable names clarified.
In general, very minor changes (I've kept all the comments even if they are blocks that should go away because I was not sure).
It's extremely difficult and probably future steps should involve putting the different blocks of code into different files, to make it more maintainable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant