Support latlonbnds #384
Open
Support latlonbnds #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NEWS.md
Outdated
| @@ -1,3 +1,6 @@ | |||
| **Version 2.24.0 2024-06-27** | |||
| - Adds support for grids where the data cells are defibe by lat_bnds and lon_bnds parameters describing the cell bounds. | |||
There was a problem hiding this comment.
are defined by by lat_bnds
adagucserverEC/CImageDataWriter.cpp
Outdated
| @@ -723,6 +723,11 @@ int CImageDataWriter::getFeatureInfo(std::vector<CDataSource *> dataSources, int | |||
| if (dataSources[d]->getDataObject(0)->cdfObject->getAttributeNE("ADAGUC_GEOJSON") != NULL) { | |||
| openAll = true; | |||
| } | |||
|
|
|||
| if (dataSources[d]->getDataObject(0)->cdfObject->getAttributeNE("USE_ADAGUCCONVERTER") != NULL) { | |||
There was a problem hiding this comment.
Should USE_ADAGUCCONVERTER be renamed to USE_ADAGUC_LATLONBNDS_CONVERTER ?
| @@ -3,6 +3,7 @@ | |||
| The adaguc-server executable is ran with various settings and configuration files. | |||
| Results are checked against expected results and should not differ. | |||
| """ | |||
|
|
|||
| import unittest | |||
| import sys | |||
| from AdagucTests.TestWMSTimeSeries import TestWMSTimeSeries | |||
There was a problem hiding this comment.
- Can you add a functional test demonstrating this dataset?
- Can you add documentation to https://github.com/KNMI/adaguc-server/tree/master/doc/format_standard ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for data where gid data cells are described by
lat_bndsandlon_bndsvariables.