Solar Terminator #404
Solar Terminator #404
Conversation
| const char *CDPPSolarTerminator::getId() { return "solarterminator"; } | ||
|
|
||
| #define SIZE 255 | ||
| void CDPPSolarTerminator::print_trace() { |
There was a problem hiding this comment.
Is print_trace still needed?
There was a problem hiding this comment.
Oh, I think this is a very old copy/paste thing. I assumed it was a standard post processor thing and didn't look twice at it. Will remove!
adagucserverEC/CDataPostProcessors/CDataPostProcessor_SolarTerminator.h
Outdated
Show resolved
Hide resolved
belentorrente
force-pushed
the
newsolarterminator
branch
from
f7bac5d
to
b58596c
Compare
| @@ -0,0 +1,27 @@ | |||
| <?xml version="1.0" encoding="UTF-8" ?> | |||
There was a problem hiding this comment.
Can you add the new option to https://github.com/KNMI/adaguc-server/blob/master/doc/configuration/Layer.md ?
Can you also write a tutorial in https://github.com/KNMI/adaguc-server/blob/master/doc/tutorials/Readme.md? E.g. copy this dataset configuration to the right place. And then looking at it in the viewer?
There was a problem hiding this comment.
Very good idea! Regarding Layer.md, I should probably add it under LiveUpdate, right?
There was a problem hiding this comment.
OK, I have a not-so-good update. Basically the legend of the solar terminator is now broken (I noticed while making a screen capture for the documentation). If I make the GetLegendGraphic call it works fine (I have added a test for that), but when running Adaguc locally and accessing the dataset from the viewer, no styles are listed.
I think this is related to the metadata db setup (readFromDb is set to false). Maybe related to the variable/dimension check? There is a comment saying If variable name equals dimension name, values are stored in the database.
Any clues how to fix this?
There was a problem hiding this comment.
In adagucserverEC/utils/XMLGenUtils.cpp, line 751, you need to add ||
metadataLayer->dataSource->dLayerType == CConfigReaderLayerTypeLiveUpdate
Not sure what other consequences this has.
This MR introduces the CDataPostProcessor that calculates the Solar Terminator, which will assign one of five standard categories to a pixel (day, night, astronomical twilight, nautical twilight, and civil twilight) based on the solar zenith angle. Three test cases have been added.
The solar terminator algorithm itself is based on a book (Astronomical Algorithms, by Jean Meeus) that provides an approximation. An old scan of the book is available here, if you're interested.
More considerations:
liveupdatewith no post processors, it will go the pre-existing route, creating an image with the timestamp.CDataWriter::addData, so I have discarded this idea (for now). So for now, and empty netCDF file is used. Another problem is that the units in the legend depend on this and I could not find the way of overwriting this in the data post processor.