Add cfg validator and fix errors (#121)

KSP-RO · Jun 11, 2022 · 9b5abf1 · 9b5abf1
1 parent ec97d9d
commit 9b5abf1
Show file tree

Hide file tree

Showing 9 changed files with 32 additions and 10 deletions.
diff --git a/.github/workflows/validateCfgFiles.yml b/.github/workflows/validateCfgFiles.yml
@@ -0,0 +1,21 @@
+name: "Validate cfg files"
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+  # Allows you to run this workflow manually from the Actions tab
+  workflow_dispatch:
+
+jobs:
+  validate-cfg-files:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repo
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 1
+      - name: Validate config files
+        uses: KSP-CKAN/KSPMMCfgParser@master
diff --git a/GameData/KerbalismConfig/Support/BeyondHome.cfg b/GameData/KerbalismConfig/Support/BeyondHome.cfg
@@ -188,7 +188,7 @@ RadiationBody:NEEDS[BeyondHome]
 }
 
 //Scaythe is magnetically inactive.  For unknown reasons, radioactive isotopes
-are slightly concentrated at the poles
+//are slightly concentrated at the poles
 RadiationBody:NEEDS[BeyondHome]
 {
   name = Scaythe

diff --git a/GameData/KerbalismConfig/Support/GPO.cfg b/GameData/KerbalismConfig/Support/GPO.cfg
@@ -40,7 +40,8 @@ RadiationBody:NEEDS[Olei]
 	radiation_model = metallic
 	radiation_inner = 1.5
 	radiation_pause = -0.004
-  
+}
+
 RadiationBody:NEEDS[Olei]
 {
 	name = Scorch

diff --git a/GameData/KerbalismConfig/Support/SSPX.cfg b/GameData/KerbalismConfig/Support/SSPX.cfg
@@ -989,7 +989,7 @@
 
 }
 
-@PART[Large_Crewed_Lab]:NEEDS[StationPartsExpansionRedux,ProfileRealismOverhaul]:AFTER[RealismOverhaul,KerbalismConfig]
+@PART[Large_Crewed_Lab]:NEEDS[StationPartsExpansionRedux,ProfileRealismOverhaul]:AFTER[RealismOverhaul]
 {
 	%MODULE[Habitat]
 	{	

diff --git a/GameData/KerbalismConfig/Support/SSTU.cfg b/GameData/KerbalismConfig/Support/SSTU.cfg
@@ -426,7 +426,7 @@
 // Only patch SSTUModularPart if it has a solar panel. 
 // This isn't fail-proof as a modular part can have switcheable solar panels and "Solar-None" as the default option,
 // but we want to avoid adding the SolarPanelFixer on parts that don't have a solar panel.
-@PART[*]:HAS[@MODULE:HAS[#name[SSTUModularPart],!#currentSolar[Solar-None]]]:NEEDS[SSTU]:AFTER[KerbalismDefault]
+@PART[*]:HAS[@MODULE:HAS[#name[SSTUModularPart],~currentSolar[Solar-None]]]:NEEDS[SSTU]:AFTER[KerbalismDefault]
 {
 	MODULE
 	{

diff --git a/GameData/KerbalismConfig/Support/USI/USI_Kontainers.cfg b/GameData/KerbalismConfig/Support/USI/USI_Kontainers.cfg
@@ -379,7 +379,7 @@
 	{
 		@textureNames = UmbraSpaceIndustries/Kontainers/Assets/Tank_01;UmbraSpaceIndustries/Kontainers/Assets/Tank_03;UmbraSpaceIndustries/Kontainers/Assets/Tank_00;UmbraSpaceIndustries/Kontainers/Assets/Tank_06;UmbraSpaceIndustries/Kontainers/Assets/Tank_07;UmbraSpaceIndustries/Kontainers/Assets/Tank_05;UmbraSpaceIndustries/Kontainers/Assets/Tank_08
 		@textureDisplayNames = Water;Waste Water;LFO;Fuel;Mono Propellant;Liquid Hydrogen;Xenon
-		!fuelTankSetups
+		!fuelTankSetups = null
 		@useFuelSwitchModule = false
 		@nextButtonText = Next Cargo Texture
 		@prevButtonText = Previous Cargo Texture
@@ -389,7 +389,7 @@
 	{
 		@textureNames = UmbraSpaceIndustries/Kontainers/Assets/Tank_01;UmbraSpaceIndustries/Kontainers/Assets/Tank_03;UmbraSpaceIndustries/Kontainers/Assets/Tank_00;UmbraSpaceIndustries/Kontainers/Assets/Tank_06;UmbraSpaceIndustries/Kontainers/Assets/Tank_07;UmbraSpaceIndustries/Kontainers/Assets/Tank_05;UmbraSpaceIndustries/Kontainers/Assets/Tank_08
 		@textureDisplayNames = Water;Waste Water;LFO;Fuel;Mono Propellant;Liquid Hydrogen;Xenon
-		!fuelTankSetups
+		!fuelTankSetups = null
 		@useFuelSwitchModule = false
 		@nextButtonText = Next Cargo Texture
 		@prevButtonText = Previous Cargo Texture
@@ -1032,7 +1032,7 @@
 	{
 		@textureNames = UmbraSpaceIndustries/Kontainers/Assets/Kontainer_10;UmbraSpaceIndustries/Kontainers/Assets/Kontainer_13;UmbraSpaceIndustries/Kontainers/Assets/Kontainer_01;UmbraSpaceIndustries/Kontainers/Assets/Kontainer_11
 		@textureDisplayNames = Food;Waste;Uraninite;Ore
-		!fuelTankSetups
+		!fuelTankSetups = null
 		@useFuelSwitchModule = false
 		@nextButtonText = Next Cargo Texture
 		@prevButtonText = Previous Cargo Texture

diff --git a/GameData/KerbalismConfig/System/Parts.cfg b/GameData/KerbalismConfig/System/Parts.cfg
@@ -9,7 +9,7 @@
 // ==============================================================================
 
 //Aviation
-@PART[SXTBuzzard|SXTmk3Cockpit52|SXTke111|25mKossak|SXTClyde|625mBonny|SXTmeadowlark|SXTEntenteCordiale|SXTGoose|SXTOsaulNoseCockpitAn225|RP0Nose-Cockpit||X1_Crew|Mark1Cockpit|RO-X1Cockpit]:NEEDS[ProfileRealismOverhaul]:AFTER[RealismOverhaul]
+@PART[SXTBuzzard|SXTmk3Cockpit52|SXTke111|25mKossak|SXTClyde|625mBonny|SXTmeadowlark|SXTEntenteCordiale|SXTGoose|SXTOsaulNoseCockpitAn225|RP0Nose-Cockpit|X1_Crew|Mark1Cockpit|RO-X1Cockpit]:NEEDS[ProfileRealismOverhaul]:AFTER[RealismOverhaul]
 {
   processConfigureExclude = true
   MODULE

diff --git a/GameData/KerbalismConfig/System/Science/HardDriveConfigs.cfg b/GameData/KerbalismConfig/System/Science/HardDriveConfigs.cfg
@@ -407,7 +407,7 @@ KERBALISM_HDD_SIZES
 	}
 }
 
-@PART[FASAGeminiPod2|FASAGeminiPod2White|ROAdvCapsule|RO-Mk1Cockpit|RO-Mk1CockpitInline|MK1CrewCabin|ok_bo_fem|ok_bo_male|rn_zond_sa|rn_lok_sa|rn_lok_bo|]:NEEDS[FeatureScience]:FOR[RO-KerbalismHardDrives]
+@PART[FASAGeminiPod2|FASAGeminiPod2White|ROAdvCapsule|RO-Mk1Cockpit|RO-Mk1CockpitInline|MK1CrewCabin|ok_bo_fem|ok_bo_male|rn_zond_sa|rn_lok_sa|rn_lok_bo]:NEEDS[FeatureScience]:FOR[RO-KerbalismHardDrives]
 {
 	!MODULE[HardDrive] {}
 	MODULE

diff --git a/GameData/KerbalismConfig/System/Sickbay.cfg b/GameData/KerbalismConfig/System/Sickbay.cfg
@@ -38,7 +38,7 @@ PARTUPGRADE:NEEDS[RP-0,FeatureComfort]
     }
 }
 
-@PART[*]:HAS[#CrewCapacity[>3],@MODULE[Habitat],!MODULE[GravityRing]!MODULE[ModuleCommand],!MODULE[Laboratory],!MODULE[LaunchClamp],!MODULE[ModuleUnpressurizedCockpit]]:NEEDS[ProfileRealismOverhaul,FeatureComfort]:AFTER[zzzKerbalism]
+@PART[*]:HAS[#CrewCapacity[>3],@MODULE[Habitat],!MODULE[GravityRing],!MODULE[ModuleCommand],!MODULE[Laboratory],!MODULE[LaunchClamp],!MODULE[ModuleUnpressurizedCockpit]]:NEEDS[ProfileRealismOverhaul,FeatureComfort]:AFTER[zzzKerbalism]
 {
     MODULE
     {
-Original file line number
+Diff line change
@@ Expand Up / @@ -989,7 +989,7 @@ @@
     }
-    @PART[Large_Crewed_Lab]:NEEDS[StationPartsExpansionRedux,ProfileRealismOverhaul]:AFTER[RealismOverhaul,KerbalismConfig]
+    @PART[Large_Crewed_Lab]:NEEDS[StationPartsExpansionRedux,ProfileRealismOverhaul]:AFTER[RealismOverhaul]
     {
     	%MODULE[Habitat]
     	{
@@ Expand Down @@