-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite some contract parameter titles to make them consistent across all contracts #2526
Open
Clayell
wants to merge
27
commits into
KSP-RO:master
Choose a base branch
from
Clayell:film
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduce battery charge needed to 1 EC to make consistent, even if this is pretty much impossible without at least 100 EC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duration that electric charge must be held for, as the parameter does not actually check that electric charge is only held for this amount of time, rather that it is continuously held (fix https://discord.com/channels/319857228905447436/512556137380315139/1344736088400461854)
Rewrite corona parameter a bit to make it clear that you only need to return the film
Require science to be transmitted for Phobos and Deimos flyby(Quadrupole has reminded me that this would require the experiment to be finished, which is unlikely for a 5 minute flyby)Require power for Mars Flyby.