Automatically update pkgver using makepkg #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSXGitHub
requested changes
Aug 29, 2021
j-waters
force-pushed
the
update-pkgver
branch
from
ab59c61 to
d264704
Compare
KSXGitHub
reviewed
Aug 30, 2021
j-waters
force-pushed
the
update-pkgver
branch
from
d264704 to
f0c680f
Compare
KSXGitHub
requested changes
Aug 30, 2021
j-waters
force-pushed
the
update-pkgver
branch
2 times, most recently
from
9988ac9 to
e6f7194
Compare
|
It seems that you're busy. Notify me by |
j-waters
force-pushed
the
update-pkgver
branch
2 times, most recently
from
bc58083 to
8befa3b
Compare
j-waters
force-pushed
the
update-pkgver
branch
from
8befa3b to
ddea9b0
Compare
|
Hi @KSXGitHub Is it ready to merge this PR? |
KSXGitHub
reviewed
Oct 16, 2021
Comment on lines
+63
to
+64
| cd /tmp/makepkg; | ||
| makepkg -od; |
KSXGitHub
reviewed
Oct 16, 2021
| if [ "$update_pkgver" = "true" ]; then | ||
| echo '::group::Updating pkgver' | ||
| echo 'Running `makepkg -od` to update pkgver' | ||
| mkdir -p /tmp/makepkg |
There was a problem hiding this comment.
There's a command called mktemp that always exists (provided by the coreutils package). It is better to use that than mkdir -p /tmp/makepkg.
|
@KSXGitHub I submitted another PR (#26) for updating the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
pkgver()function exists, the PKGBUILD file will be copied into a new temporary directory,makepkg -odwill be run, and then the new PKGBUILD file will be the one that is copied into the aur repo.makepkg -od:-oskips building, but still runspkgver()-dskips dependency checks, which is fine as long as no dependencies (other than git) are used in thepkgver()function