Merged
Conversation
- 헬퍼 메소드 추출
Contributor
|
보통 Validator라고 하면 엔티티의 상태를 검증하는 역할을 하게 될것 같은데, DB에서 엔티티를 직접 가져오는 것까지 담당한다면 "한 클래스가 많은 책임을 담당하는게 아닌가?" 라는 생각이 들었습니다. 감정밴드의 유효성을 판단 로직을 별도의 클래스에서 처리하는 것은 매우 좋다고 생각합니다! |
Member
Author
|
@mjkhub |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EntityValidator에게 일임한다GlobalExceptionHandler까지 예외를 던져서 클라이언트에 오류 코드를 내려줌