Merged
Conversation
Contributor
Author
|
추가적으로, 제가 개발한 API 리팩토링은 모두 끝났습니다! 기훈님이 개발하신 부분 조금 맡아서 리팩토링 진행해볼까요? 이제 하루 혹은 이틀 정도만 다듬으면 끝날 것 같네용 |
sudo-Terry
reviewed
Jul 2, 2025
|
|
||
| @Query("SELECT eb.id FROM EmotionBand eb where eb.creator.id =:memberId") | ||
| List<Long> findEmotionBandIdListByCreator(Long memberId); | ||
| List<Long> findPkListByCreator(Long memberId); |
Contributor
Author
There was a problem hiding this comment.
흠 당시에는 메소드 명이 길어서 수정해봤는데, 지금보니까 그냥 원래대로 두는게 더 나아보이네요.. ㅎ
Member
There was a problem hiding this comment.
개인적으로 snake_case에 좀 더 익숙한데 camelCase가 길어지면 유난히 더 길어보이고 잘 안읽히는 것 같아요
sudo-Terry
approved these changes
Jul 2, 2025
Member
sudo-Terry
left a comment
sudo-Terry
left a comment
There was a problem hiding this comment.
고생 많으셨습니다~ 제 파트도 오늘 이어서 해볼께요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
프로필 페이지 API 와 관련된 코드를 조금 다듬었습니다.
컨트롤러에서 직접 DTO를 생성하던 부분을 파서를 도입하여 코드를 다듬었습니다.
그리고, 사용하지 않는 코드와 메서드 명을 더 직관적으로 바꾸었습니다.