Conversation
Member
sudo-Terry
commented
Jul 2, 2025
sudo-Terry
commented
- 유효성 검사를 마찬가지로 EntityValidator에게 위임한다
- 테스트에서 유효성 검사에 대한 단위 테스트를 제거, 서비스 로직만 검증한다
- 반복되는 코드를 메소드를 추출
- 연관 객체 필드 업데이트
- 네이밍 변경
- 유효성 검사를 마찬가지로 EntityValidator에게 위임한다 - 테스트에서 유효성 검사에 대한 단위 테스트를 제거, 서비스 로직만 검증한다 - 반복되는 코드를 메소드를 추출 - 연관 객체 필드 업데이트 - 네이밍 변경
sudo-Terry
force-pushed
the
refactor/archive-service
branch
from
04260dd to
89d452b
Compare
Member
Author
|
동시성 문제가 여기도 있는데 이건 후속 pr 날려서 할게요 |
mjkhub
reviewed
Jul 2, 2025
| emotionBandRepository.save(updatedEmotionBand); | ||
| memberRepository.save(updatedMember); | ||
|
|
||
| updateCounts(emotionBand, member, false); |
Contributor
There was a problem hiding this comment.
지금 봤는데, 이렇게 감정밴드 보관, 취소 로직을 한번에 태우는 흐름이 좋은 것 같습니다!
Contributor
There was a problem hiding this comment.
@sudo-Terry 고생하셨습니다! 예전보다 훨씬 깔끔해진 것 같아요.
엇 동시성 문제는 조용히 넘어가려고 했는데, 좋습니다! 저도 후속 PR 날려볼게요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.