feat: 메인페이지 공지사항 크롤링 비동기 처리 #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 공지사항 크롤링 요청 총 5번을 비동기 처리로 시간 단축
Member
Author
|
공지사항 기능의 요청을 비동기 처리하여 성능을 개선함.
|
cjh-19
commented
Dec 4, 2024
| ); | ||
| try { | ||
| // 공지사항 비동기 호출 | ||
| CompletableFuture<List<MainResponseDto.NoticeItem>> generalNotices = CompletableFuture.supplyAsync(() -> |
Member
Author
There was a problem hiding this comment.
- CompletableFuture.supplyAsync()를 사용하여 공지사항 데이터를 병렬로 가져옴
- 각 카테고리("", "0", "1", "2", "4")의 데이터를 별도로 호출하여 병렬 처리
| .collect(Collectors.toList()) | ||
| : List.of(); | ||
| // 모든 공지사항 작업 완료 대기 | ||
| CompletableFuture.allOf( |
Member
Author
There was a problem hiding this comment.
- CompletableFuture.allOf()로 동기화 -> 모든 CompletableFuture 작업이 완료될 때까지 대기
| events = (calendarResponseDto != null) ? calendarResponseDto.getEvents() : new CalendarResponseDto.EventGroup(); | ||
| } | ||
| // 공지사항 결과 병합 | ||
| MainResponseDto.Notices notices = new MainResponseDto.Notices( |
Member
Author
There was a problem hiding this comment.
- Future.get()를 사용하여 각 결과를 가져와 MainResponseDto.Notices 객체로 병합
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #218