Merged
Conversation
KaBooMa
requested changes
Apr 27, 2025
Owner
KaBooMa
left a comment
KaBooMa
left a comment
There was a problem hiding this comment.
This might be better as a static class w/ static actions for subscribing on / off of.
Thinking like... MoneyManager becomes static (Just Money??). You have actions such as:
public event Action OnBalanceChanged, whatever.
Then static methods like you have. I don't think we need OnCreated and OnDestroyed once we get a good entry point for all mods. Like a ... OnGameLoaded action for them to use.
Thoughts??
Owner
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.