Repository navigation
Enforce evidence rules in validate; fix the 0.1.0 review findings - #1
Merged
Merged
Conversation
The README promised that `validate` enforces "no run, no level bump", but a hand-edited current_level passed. validate now replays runs.yaml from L0: each level change must start where earlier runs left the feature, and current_level must equal where the replay ends. verified-fixed likewise now needs a run that lists the issue in issues_verified; `set … status verified-fixed` and the dashboard menu refuse it. Also from the 0.1.0 review: - add-run rejects a level change whose "from" is not the current level - a backdated run no longer overwrites a newer last_validated - `set <f> reverify` rejects values other than true/false/1/0 (was: false) - validate reports null/scalar list entries and non-list surfaces/children instead of throwing Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…0 review - store: write every tracker file via temp file + rename, so a crash or a sync client never sees a truncated file (multi-file edits are still sequential, not transactional) - server: malformed JSON, null or array bodies are a 400, not a 500 - dashboard: hold a row's weight buttons while a save is in flight, so a double-click can't send the same value twice - cli: a value flag with no value is an error (`serve --port` meant port 1) - cli: `init --root` is written to the config, relative to the data dir - store: drop a stale SURFACES.md once the last surfaces file is gone - refactor: DIM_ICON/SEV_ORDER/cell move to src/format.mjs and RUN_REF to schema.mjs (still re-exported from validate.mjs); demo output unchanged Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixes from a code review of 0.1.0, in two commits.
1. Enforce the evidence rules in
validate, not just in the CLI (64956b5)validateenforces "no run, no level bump", but a hand-editedcurrent_levelused to pass.validatenow replaysruns.yamlin file order from L0. Eachlevel_changesentry must start where the earlier runs left the feature, andcurrent_levelmust equal where the replay ends.verified-fixedcan only come from a run.set <issue> status verified-fixedand the dashboard menu refuse it, andvalidaterejects averified-fixedissue that no run lists inissues_verified.add-runrejects a level change that doesn't start at the feature's current level, and a backdated run no longer overwrites a newerlast_validated.set <f> reverifyaccepts onlytrue/false/1/0. Before,yeswas silently stored asfalse.validatereports a bare-list entry, orsurfaces:/children:that isn't a list, instead of crashing.2. Remaining review findings (
7d02cb1)null, an array) with 400 instead of 500.serve --port) is an error. Before,--portalone meant port 1.init --rootis now written to the config; before, it was ignored.SURFACES.mdis removed once the last surfaces file is gone.DIM_ICON,SEV_ORDERandcellmove tosrc/format.mjs, andRUN_REFmoves toschema.mjs(still re-exported fromvalidate.mjs).Why
The evidence rules are the product. CONTRIBUTING.md says a change that lets a level rise without a run needs a very good reason, but the validator itself let that happen.
For reviewers
verified-fixedwith no run) now failsvalidate. The fix is to record the missing run. Because of this, the next release should be 0.2.0, not 0.1.1.package.jsonis unchanged; the version bump happens at release time, as CONTRIBUTING.md says.add-issuewritesissues.yamland thenfeatures.yaml) are atomic per file, not as a whole.[Unreleased]in CHANGELOG.md. README.md and docs/SCHEMA.md describe the replay rule.Testing
node --test: 60/60 pass. 12 tests are new (8 in the first commit, 4 in the second), and 2 validate tests were updated to give the levels they use a backing run.qa-tracker validate --dir examples/demopasses, and the demo'sSTATUS.md/SURFACES.mdre-render byte-identical.reverify yes,status verified-fixedand a bare-are each now rejected with a clear message.🤖 Generated with Claude Code