Do not process italic syntax on links. #3
Conversation
| @@ -9,7 +9,7 @@ import Foundation | |||
|
|
|||
| open class MarkdownItalic: MarkdownCommonElement { | |||
|
|
|||
| fileprivate static let regex = "(.?|^)(\\*|_)(?=\\S)(.+?)(?<![\\*_\\s])(\\2)" | |||
There was a problem hiding this comment.
This regex was implemented in bmoliveira@761a30e to "fix" when the italic syntax is combined with bold and/or other characters, but it was capturing the preceding character (e.g., when capturing _italic_, it would capture _italic_ with the space before. I reverted it as it doesn't make much sense for our use case, and it still works with bold text.
kublaios
requested review from
a team,
russellporter,
alex-deutsch,
ahmad-atef and
AymenLetaief
and removed request for
a team
| let attributedSubstring = attributedString.attributedSubstring(from: range) | ||
| var effectiveRange = NSRange(location: 0, length: 0) | ||
| let atributes = attributedSubstring.attributes(at: 0, effectiveRange: &effectiveRange) | ||
| return atributes.keys.contains(attribute) |
There was a problem hiding this comment.
nit: (assuming we don't need to check the whole range) I think it can be simplified to:
attributedString.attribute(attribute, at: range.position, effectiveRange: nil) != nil| private func attributedString( | ||
| _ attributedString: NSAttributedString, | ||
| hasAttribute attribute: NSAttributedString.Key, | ||
| at range: NSRange |
There was a problem hiding this comment.
It looks to me that this function only checks that there is an attribute at the first position in the range, right?
If that's intended maybe we can change the param to at location: Int to make it clearer
There was a problem hiding this comment.
Actually, it turned out that we don't need this check at all - just updating the regex was sufficient, so I reverted this part. Thanks for the nudge!
There was a problem hiding this comment.
Updated the demo template to showcase more cases (link with underscores and bold+italic vs italic+bold)
| @@ -159,8 +159,8 @@ open class MarkdownParser { | |||
| (.bold, bold), | |||
| (.italic, italic), | |||
| (.strikethrough, strikethrough), | |||
| (.link, link), | |||
There was a problem hiding this comment.
When the link was being parsed before, it would join the text coming after the link, and the autolink would incorrectly make the following text a part of the link.
Steps to reproduce
[schedule](https://care.kaiahealth.com/appointments/embed_appt?dietitian_id=1167309)through the healthie chat and click on itActual Result
Expected result