cuda with index instead of default "cuda" #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add **kwargs optional arguments to ImageDataManager, which will ensure flexibility of the custom and registered dataset
In `feature_extractor.py`, images are put to `self.device` every time it's called. It's necessary to consider this because we should make sure that images(the inputs) and the model parameters are on the same device. However, the current code cannot achieve this with the default setting. Currently, Feature extractor is initialized with the default `device='cuda'`, it's ambiguous for that "cuda" with no specified index may point to different GPUs. I modified a line which set `self.cuda` with a specified device index when none is provided.
|
Besides, there's also another modification of kwargs, which is still open in the PR list. |
|
Sorry for the late reply.
What if you set
What's the reason for this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
feature_extractor.py, images are put toself.deviceevery time it's called.It's necessary to consider this because we should make sure that images(the inputs) and the model parameters are on the same device.
However, the current code cannot achieve this with the default setting. Currently, Feature extractor is initialized with the default
device='cuda', it's ambiguous for that "cuda" with no specified index may point to different GPUs."cuda" points to different devices during initialization and being called
I modified a line which set
self.cudawith a specified device index when none is provided.