Skip to content

chore(catalog): remove dataformats and loadbalancers from generated catalog - #197

Merged
lordrip merged 1 commit into
KaotoIO:mainfrom
shivamG640:catalog-cleanup
Sep 29, 2026
Merged

lordrip merged 1 commit into
KaotoIO:mainfrom
shivamG640:catalog-cleanup

Conversation

@shivamG640

@shivamG640 shivamG640 commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Remove the DataFormatHandler and LoadBalancerHandler catalog entry
generators along with their corresponding camel-catalog-aggregate-dataformats
and camel-catalog-aggregate-loadbalancers output files across all runtimes
and versions.

Changes:

  • Delete DataFormatHandler.java and LoadBalancerHandler.java
  • Remove their invocations from CamelCatalogGenerator.java
  • Delete LoadBalancerHandlerTest.java
  • Remove DataFormatHandler and LoadBalancerHandler tests and
    related fields from CamelCatalogHandlerTest.java
  • Update GenerateCatalogWithRedHatVersionTest expected file count: 17 → 15
  • Regenerate all catalog indexes (hash filenames updated) to reflect
    the removed output files
  • Update catalog/index.json with new index file hashes for all versions

Summary by CodeRabbit

  • Catalog Changes
    • Removed the aggregated data format and load balancer catalogs from supported Camel Main, Camel Quarkus, and Camel Spring Boot catalog listings.
    • Load balancer catalog details, including configuration properties and validation schemas, are no longer available in these catalog listings.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: f9bcc059-6903-4d73-8772-f8fd7857284b

📥 Commits

Reviewing files that changed from the base of the PR and between 0ce2754 and 35eb30c.

📒 Files selected for processing (22)
  • catalog/camel-main/4.10.7.redhat-00009/index-29478f1b.json
  • catalog/camel-main/4.10.7/index-6edb188d.json
  • catalog/camel-main/4.14.9/index-fa6ed931.json
  • catalog/camel-main/4.18.3.redhat-00005/index-28f3a205.json
  • catalog/camel-main/4.18.4/index-ad32821b.json
  • catalog/camel-main/4.22.1/index-bc828f90.json
  • catalog/camel-quarkus/3.20.0.redhat-00011/index-136dd431.json
  • catalog/camel-quarkus/3.20.4/index-1bf23120.json
  • catalog/camel-quarkus/3.27.4/index-169c5bda.json
  • catalog/camel-quarkus/3.33.0.redhat-00010/index-a0b5f0d.json
  • catalog/camel-quarkus/3.33.1/index-db5cafba.json
  • catalog/camel-quarkus/3.36.0/index-126da57b.json
  • catalog/camel-springboot/4.10.7.redhat-00013/index-f2f7a3eb.json
  • catalog/camel-springboot/4.10.9/index-1db22b9a.json
  • catalog/camel-springboot/4.14.9/index-e7de216.json
  • catalog/camel-springboot/4.18.3.redhat-00006/index-b3a1af95.json
  • catalog/camel-springboot/4.18.4/index-718aa145.json
  • catalog/camel-springboot/4.22.1/index-d73836e3.json
  • catalog/index.json
  • src/main/java/io/kaoto/camelcatalog/generator/camel/CamelCatalogGenerator.java
  • src/test/java/io/kaoto/camelcatalog/generator/camel/CamelCatalogHandlerTest.java
  • src/test/java/io/kaoto/camelcatalog/versions/GenerateCatalogWithRedHatVersionTest.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The generator no longer emits data-format or load-balancer aggregate catalogs. Catalog indexes remove references to both catalog types across Camel Main, Camel Quarkus, and Camel Spring Boot. Load-balancer aggregate files are deleted, and generation tests are updated.

Changes

Catalog scope and generation

Layer / File(s) Summary
Stop generating aggregate catalogs
src/main/java/io/kaoto/camelcatalog/generator/camel/CamelCatalogGenerator.java
The generator no longer imports or generates data-format and load-balancer aggregate catalogs.
Remove catalog entries and files
catalog/camel-main/*/camel-catalog-aggregate-loadbalancers-*.json, catalog/camel-quarkus/*/camel-catalog-aggregate-loadbalancers-*.json, catalog/camel-main/*/index-*.json, catalog/camel-quarkus/*/index-*.json, catalog/camel-springboot/*/index-*.json, catalog/index.json
Load-balancer aggregate files are deleted. The versioned indexes remove data-format and load-balancer entries. The top-level index updates referenced index filenames.
Update generation tests
src/test/java/io/kaoto/camelcatalog/generator/camel/CamelCatalogHandlerTest.java, src/test/java/io/kaoto/camelcatalog/versions/GenerateCatalogWithRedHatVersionTest.java
Tests remove data-format and load-balancer catalog checks. The default-value type check covers language properties, and the expected generated file count changes to 15.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~15 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing dataformats and loadbalancers from the generated catalog.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Warning

Tools execution failed with the following error:

Failed to run tools: Ping-pong health check failed


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the catalog rows,
Then hops where each deleted entry goes.
The load-balancer pages take their leave,
While smaller test counts now align.
I nibble clover, close the file,
And bound along the index aisle.

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@lordrip
lordrip merged commit 8dd6d54 into KaotoIO:main Sep 29, 2026
4 checks passed
@shivamG640
shivamG640 deleted the catalog-cleanup branch September 29, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants