Support updated JSON format in Schwab Equity Award parser

[thibwk]

Schwab have now updated their website to:

• allow the whole history of Equity Awards account to be downloaded (previously only the last 4 years were made available)
• via a simple Export button, in an updated JSON format (and CSV and XML).

This PR updates the Schwab Equity Award parser to work with this updated format (while still supporting the previous one).

[m01]

Note: a few lines below (line 311+ in the new code/241+ in the old code - I can't add a comment there directly sadly) the _normalize_split() function seems to assume that the data is about Alphabet shares. I think some check on the stock symbol might be prudent to avoid accidentally scaling some other stock's values according to the Alphabet split, in cases where the user happens to also use Schwab as broker for employer-issued equity.

[thibwk]

Yes that's right, that's for Alphabet's stock split. I am not sure if Schwab gives the same data format as parsed by this code for other accounts than the Google Equity Awards ones which can only have GOOG and GOOGL.
But I agree it'd be better to also check on the stock ticker name to be safe.

Not directly relevant to this PR though.

[m01]

The equity awards accounts and this JSON format are not unique to GOOG/GOOGL stocks, but I think this JSON format may be unique to equity awards accounts.

[KapJI]

It'd be great actually to have some JSON/CSV file in resources with information about splits to have general support for them instead of hardcoding a specific one directly in the code.

[vmartinv]

To me it seems we have two parsers for the same thing, in schwab.py there's _read_schwab_awards which parses the csv format of this new export (instead of json). If they are equivalent I'd rather have the csv format.

[thibwk]

To me it seems we have two parsers for the same thing, in schwab.py there's _read_schwab_awards which parses the csv format of this new export (instead of json). If they are equivalent I'd rather have the csv format.

Fair question, but the new CSV file format that Google employees get on their Equity Awards Account appear to have a different format, not supported by this parser.
e.g. the headers I see is:

Date	Action	Symbol	Description	Quantity	FeesAndCommissions	DisbursementElection	Amount	AwardDate	AwardId	VestDate	VestFairMarketValue	Type	Shares	SalePrice	SubscriptionDate	SubscriptionFairMarketValue	PurchaseDate	PurchasePrice	PurchaseFairMarketValue	DispositionType	GrantId	GrossProceeds

That doesn't seem to match

capital-gains-calculator/cgt_calc/parsers/schwab.py

Line 183 in 2beffd6

headers = [

.

In other words, Schwab seems to export data in different formats for different types of accounts?

[m01]

In other words, Schwab seems to export data in different formats for different types of accounts?

I thought the CSV parser was for "normal" individual brokerage accounts, and the equity awards JSON parser was for equity awards accounts.

[vmartinv]

That doesn't seem to match

capital-gains-calculator/cgt_calc/parsers/schwab.py

Line 183 in 2beffd6

headers = [

No, that’s just the normal transaction parser. There are two parsers in schwab.py, the award parser is in the function ‘_read_schwab_awards’

[vmartinv]

Also note that the csv parser for Schwab (both of them) are being fixed in #459

[KapJI]

Thanks for finding how to export more data!