Test for splits #541
Draft
Test for splits #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you fix this issue? |
|
I'm afraid I might need some support with this. In my mind, splits are basically an accounting trick: what was considered 2 stock yesterday is 10 units today, but there is no other effect. I tried to implement this above by changing the past acquisitions/disposals to operate in post-split space, but this leads to issues about pre-split reporting (if you sold one of the two units before split, it's 1 unit, not 5). This has been used in One alternative I see is to enhance the WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Failing, do not merge) test showing wrong handling for stock splits.