Skip to content

refactor : removed duplicate activeIndex and active properties in tabs() Quick API - #3199

Open
tmdeveloper007 wants to merge 6 commits into
Karanjot786:mainfrom
tmdeveloper007:#3194
Open

refactor : removed duplicate activeIndex and active properties in tabs() Quick API#3199
tmdeveloper007 wants to merge 6 commits into
Karanjot786:mainfrom
tmdeveloper007:#3194

Conversation

@tmdeveloper007

Copy link
Copy Markdown

Summary of What Has Been Done

Removed the duplicate active property in the tabs() Quick API function and added proper activeIndex support to the Tabs constructor.

Changes Made

packages/ui/src/Tabs.ts

  • Added activeIndex?: number option to TabsOptions interface
  • Used it in the constructor to initialize _activeIndex

packages/quick/src/widgets.ts

  • Removed duplicate activeIndex: opts?.active ?? 0, active: opts?.active ?? 0 (both set to the same value)
  • Removed as any cast since activeIndex is now a valid TabsOptions property
  • Kept the active name from the quick API (mapping to activeIndex internally)

Impact it Made

Cleans up dead code, removes the as any type cast, and makes the Tabs widget API more complete. The TabsOptions interface now properly exposes the initial tab index option.

Closes #3194

**Note: Please assign this PR to the tmdeveloper007 account.

@github-actions github-actions Bot added area:core @termuijs/core area:ui @termuijs/ui type:testing +10 pts. Tests. labels Jul 27, 2026
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@tmdeveloper007, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 45 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: accc0b6d-6666-4046-b2f3-ce97d0a088ee

📥 Commits

Reviewing files that changed from the base of the PR and between 48f63a1 and 9641abc.

📒 Files selected for processing (7)
  • packages/core/src/history/CommandHistory.test.ts
  • packages/core/src/history/CommandHistory.ts
  • packages/motion/src/interpolate.ts
  • packages/quick/src/widgets.ts
  • packages/store/src/immutable.test.ts
  • packages/store/src/immutable.ts
  • packages/ui/src/Tabs.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:core @termuijs/core area:ui @termuijs/ui type:testing +10 pts. Tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor : remove duplicate activeIndex and active properties in tabs() Quick API

1 participant