fix : correct RGB components in grayscale distance calculation in Color.ts - #3235
fix : correct RGB components in grayscale distance calculation in Color.ts#3235tmdeveloper007 wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 47 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of What Has Been Done
Fixed a variable reuse bug in
packages/core/src/style/Color.tswhere the ANSI-256 grayscale distance calculation incorrectly usedr_cfor all three color channels (r,g, andb). Introducedr_gray,g_gray, andb_grayvariables with the correct array offsets.Changes Made
packages/core/src/style/Color.ts
r_c = ANSI256_RGB[grayColor * 3]reuse with three separate variables:r_gray,g_gray, andb_graywith correct array offsetsdistGraycalculation to use all three correct gray componentsImpact it Made
Corrected ANSI-256 color conversion accuracy for grayscale colors. The closest grayscale is now selected based on proper Euclidean distance across all three RGB channels.
Closes #3230
Note: Please assign this PR to the
tmdeveloper007account.