Skip to content

fix : correct RGB components in grayscale distance calculation in Color.ts - #3235

Open
tmdeveloper007 wants to merge 1 commit into
Karanjot786:mainfrom
tmdeveloper007:#3230
Open

fix : correct RGB components in grayscale distance calculation in Color.ts#3235
tmdeveloper007 wants to merge 1 commit into
Karanjot786:mainfrom
tmdeveloper007:#3230

Conversation

@tmdeveloper007

Copy link
Copy Markdown

Summary of What Has Been Done

Fixed a variable reuse bug in packages/core/src/style/Color.ts where the ANSI-256 grayscale distance calculation incorrectly used r_c for all three color channels (r, g, and b). Introduced r_gray, g_gray, and b_gray variables with the correct array offsets.

Changes Made

packages/core/src/style/Color.ts

  • Replaced the single r_c = ANSI256_RGB[grayColor * 3] reuse with three separate variables: r_gray, g_gray, and b_gray with correct array offsets
  • Fixed distGray calculation to use all three correct gray components

Impact it Made

Corrected ANSI-256 color conversion accuracy for grayscale colors. The closest grayscale is now selected based on proper Euclidean distance across all three RGB channels.

Closes #3230

Note: Please assign this PR to the tmdeveloper007 account.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@tmdeveloper007, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 47 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3c51b81a-86d8-4ce7-a162-53a13237dff3

📥 Commits

Reviewing files that changed from the base of the PR and between 48f63a1 and 52b9f3e.

📒 Files selected for processing (1)
  • packages/core/src/style/Color.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the area:core @termuijs/core label Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:core @termuijs/core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix : wrong variable used in grayscale distance calculation in Color.ts

1 participant