Skip to content

fix: add safety checks - #3335

Open
saurabhhhcodes wants to merge 1 commit into
Karanjot786:mainfrom
saurabhhhcodes:fix4897-34417
Open

fix: add safety checks#3335
saurabhhhcodes wants to merge 1 commit into
Karanjot786:mainfrom
saurabhhhcodes:fix4897-34417

Conversation

@saurabhhhcodes

@saurabhhhcodes saurabhhhcodes commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved keyboard tab selection in the widget gallery by ensuring numeric keys are interpreted consistently.

@github-actions github-actions Bot added type:bug +10 pts. Bug fix. area:examples Example apps. labels Jul 31, 2026
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f0c7b4a0-0ca8-4434-b23e-f6d078f89dea

📥 Commits

Reviewing files that changed from the base of the PR and between 48f63a1 and 537addb.

📒 Files selected for processing (1)
  • examples/widget-gallery/src/index.ts

📝 Walkthrough

Walkthrough

The widget gallery now passes radix 10 when WidgetGalleryApp.handleKey parses tab-selection keys.

Changes

Widget gallery input handling

Layer / File(s) Summary
Explicit decimal key parsing
examples/widget-gallery/src/index.ts
WidgetGalleryApp.handleKey now calls parseInt with radix 10 for tab-selection keys.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: karanjot786

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided, so the required description, issue link, package, change type, checklist, and reviewer notes are missing. Complete the repository template, including the change summary, linked issue, affected package, type, checklist, and required notes.
Title check ❓ Inconclusive The title uses a valid format but is too generic and does not identify the parseInt radix change. Use a specific title such as "fix: specify radix for tab key parsing".
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:examples Example apps. type:bug +10 pts. Bug fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant