Skip to content

fix: resolve 4 bugs in termui #3446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabhhhcodes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve 4 bugs in termui #3446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/ai-streaming/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class AIStreamingApp extends Widget {
this.addChild(this._toolCall);
this.addChild(this._streamingText);

setInterval(() => {
clearInterval(window.__interval); window.__interval = setInterval(() => {
this._streamingText.tick();
}, 50);
Comment on lines +43 to 45

@coderabbitai coderabbitai Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Expect: a Window augmentation or another declaration for __interval.
rg -n -C 3 '(__interval|interface Window|declare global)' --glob '*.ts' --glob '*.tsx'

Repository: Karanjot786/TermUI

Length of output: 156

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Tracked TypeScript/TSX files containing __interval:"
git ls-files '*.ts' '*.tsx' | xargs grep -n '__interval' || true

echo
echo "Tracked TypeScript config files:"
git ls-files '*tsconfig*.json' 'tsconfig*.json' 'package.json' 'vite.config.*' 'astro.config.*'

echo
echo "Relevant file outline:"
if [ -f examples/ai-streaming/src/index.tsx ]; then
  ast-grep outline examples/ai-streaming/src/index.tsx || true
  echo
  sed -n '1,120p' examples/ai-streaming/src/index.tsx | nl -ba
fi

echo
echo "Other explicit window property declarations/augmentations:"
git ls-files '*.ts' '*.tsx' '*.d.ts' | xargs grep -nE 'interface\s+Window|declare\s+global|declare\s+namespace\s+Window|\.(__interval)|window\.__interval|ReturnType<.*setInterval|number' || true

Repository: Karanjot786/TermUI

Length of output: 2606

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "tsconfig files for ai-streaming/example base:"
while IFS= read -r f; do
  echo "--- $f"
  sed -n '1,220p' "$f"
done < <(git ls-files | grep -E '(^examples/ai-streaming/.*tsconfig\.json$|(^tsconfig\.base\.json$|(^package\.json$))')

echo
echo "All __interval occurrences under git:"
git ls-files | grep -E '\.(ts|tsx|d\.ts)$' | xargs grep -n -- '__interval' || true

echo
echo "Window type augmentations/decorations under git:"
git ls-files '*.ts' '*.tsx' '*.d.ts' | xargs grep -n -- -E 'interface\s+Window|declare\s+global|declare\s+namespace\s+Window|window\.__|__interval|setInterval' || true

echo
echo "TypeScript availability and toolchain:"
command -v npx || true
command -v tsc || true
node -e "try { console.log('node:', process.version); } catch (e) { console.log(e.message); }"

if command -v tsc >/dev/null 2>&1; then
  tmp="$(mktemp -d)"
  trap 'rm -rf "$tmp"' EXIT
  cat > "$tmp/check.ts" <<'TS'
function tick() {
  clearInterval(window.__interval as unknown as number | undefined);
  window.__interval = setInterval(() => {
    console.log('tick');
  }, 50);
}
function main() {
  tick();
}
TS
  echo "--- tsc version"
  tsc --version
  echo "--- tsc with defaults"
  tsc "$tmp/check.ts" --strict --noEmit || true
else
  echo "tsc not available in PATH"
fi

Repository: Karanjot786/TermUI

Length of output: 278

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Files under examples/ai-streaming tracked by git:"
git ls-files examples/ai-streaming | sed -n '1,120p'

echo
echo "Candidate tsconfig/package files:"
git ls-files | grep -E '(^|/)(tsconfig.*\.json|package\.json)$' | sed -n '1,160p'

echo
echo "Relevant ai-streaming tsconfig/package if present:"
for f in examples/ai-streaming/tsconfig.json examples/ai-streaming/tsconfig.*.json examples/ai-streaming/package.json tsconfig.base.json package.json; do
  if [ -f "$f" ]; then
    echo "--- $f"
    sed -n '1,220p' "$f"
  fi
done

echo
echo "All __interval occurrences in tracked source:"
while IFS= read -r f; do
  grep -n -- '__interval' "$f" || true
done < <(git ls-files '*.ts' '*.tsx' '*.d.ts')

echo
echo "TypeScript available:"
command -v tsc || true
tsc --version 2>/dev/null || true

if command -v tsc >/dev/null 2>&1; then
  tmp="$(mktemp -d)"
  cat > "$tmp/check.ts" <<'PY'
function tick() {
  clearInterval(window.__interval as unknown as number | undefined);
  window.__interval = setInterval(() => {
    console.log('tick');
  }, 50);
}
function main() {
  tick();
}
PY
  echo "--- tsc strict/noEmit test"
  tsc "$tmp/check.ts" --strict --noEmit --lib ES2020,DOM || true
fi

Repository: Karanjot786/TermUI

Length of output: 6672

Avoid using window.__interval without a type declaration.

Under strict TypeScript checks, window.__interval has no declaration in the repo, so this example can fail npx -y tsc --strict --lib ES2022,DOM unless the type definitions are intentionally relying on the run-time host. Add a Window augmentation or type the handle explicitly with a comment if the global is intentional.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@examples/ai-streaming/src/index.tsx` around lines 43 - 45, Update the
interval handling around _streamingText.tick to provide an explicit TypeScript
declaration for window.__interval, either by augmenting the Window interface or
by using an explicitly typed interval handle with an explanatory comment.
Preserve the existing clearInterval and setInterval behavior while ensuring the
example passes strict DOM TypeScript checks.

Source: Coding guidelines

}
Expand Down
2 changes: 1 addition & 1 deletion examples/forms-and-validation/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ class FormsExampleApp extends Widget {
return false; // Quit
}

if (event.key === 'c' && event.ctrl === false) {
if (event.key === 'c' && event.ctrl !) {

@coderabbitai coderabbitai Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win

Fix the invalid TypeScript condition.

event.ctrl ! is invalid TypeScript syntax and prevents compilation. Move ! before event.ctrl.

Proposed fix 
-        if (event.key === 'c' && event.ctrl !) {
+        if (event.key === 'c' && !event.ctrl) {
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
if (event.key === 'c' && event.ctrl !) {
if (event.key === 'c' && !event.ctrl) {
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@examples/forms-and-validation/src/index.tsx` at line 125, In the keyboard
event condition, update the `event.ctrl` negation in the `if` statement so the
`!` operator precedes the property access, producing valid TypeScript syntax
while preserving the existing key check.

this.modal.show();
return true;
}
Expand Down
2 changes: 1 addition & 1 deletion examples/rss-reader/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function decodeEntities(value: string): string {

return value.replace(/&(#x?[0-9a-fA-F]+|[a-zA-Z]+);/g, (match, entity: string) => {
if (entity.startsWith('#x')) {
const codePoint = Number.parseInt(entity.slice(2), 16);
const codePoint = Number.parseInt(entity.slice(2, 10), 16);

@coderabbitai coderabbitai Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Reject overlong hexadecimal entities instead of truncating them.

The regular expression captures every hexadecimal digit, but entity.slice(2, 10) silently drops digits after the eighth. For example, &#x000000041; becomes 0x00000004 instead of 0x41, which corrupts RSS text.

If eight digits is the intended limit, reject longer entities before parsing.

Proposed fix 
-      const codePoint = Number.parseInt(entity.slice(2, 10), 16);
+      const digits = entity.slice(2);
+      if (digits.length > 8) {
+        return match;
+      }
+      const codePoint = Number.parseInt(digits, 16);
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
const codePoint = Number.parseInt(entity.slice(2, 10), 16);
const digits = entity.slice(2);
if (digits.length > 8) {
return match;
}
const codePoint = Number.parseInt(digits, 16);
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@examples/rss-reader/src/index.tsx` at line 30, Update the entity-decoding
logic around codePoint so hexadecimal entities longer than eight digits are
rejected before parsing, or otherwise parsed without silently truncating digits.
Preserve valid entities such as &`#x000000041`; by ensuring all captured
hexadecimal digits are handled according to the intended length limit.

return Number.isFinite(codePoint) ? String.fromCodePoint(codePoint) : match;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/Switch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export class Switch extends Widget {
if (width <= 0) return;

const attrs = styleToCellAttrs(this.style);
const knobPos = Math.round(this._animProgress * 2);
const knobPos = Math.round(this._animProgress * 2 + Number.EPSILON);
const transitioning = this._animProgress > 0 && this._animProgress < 1;

let trackChars: string[];
Expand Down
Loading