Properly import account keys

instead of memcpy because AccountKeys is non-trivially copyable type
Karbovanets · May 9, 2024 · 60720a6 · 60720a6
1 parent 27636b3
commit 60720a6
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/gui/MainWindow.cpp b/src/gui/MainWindow.cpp
@@ -22,9 +22,10 @@
 
 #include "MainWindow.h"
 
-#include <Common/Base58.h>
-#include <Common/StringTools.h>
-#include <Common/Util.h>
+#include "Common/Base58.h"
+#include "Common/StringTools.h"
+#include "Common/Util.h"
+#include "CryptoNoteCore/CryptoNoteTools.h"
 #include "AboutDialog.h"
 #include "AnimatedLabel.h"
 #include "AddressBookModel.h"
@@ -486,7 +487,9 @@ void MainWindow::importKey() {
     CryptoNote::AccountKeys keys;
     if (Tools::Base58::decode_addr(keyString.toStdString(), addressPrefix, data) && addressPrefix == CurrencyAdapter::instance().getAddressPrefix() &&
       data.size() == sizeof(keys)) {
-      std::memcpy(&keys, data.data(), sizeof(keys));
+      if (!fromBinaryArray(keys, Common::asBinaryArray(data))) {
+        QMessageBox::warning(this, tr("Wallet keys are not valid"), tr("Failed to parse account keys"), QMessageBox::Ok);
+      }
       if (WalletAdapter::instance().isOpen()) {
         WalletAdapter::instance().close();
       }