Skip to content

Conversation

roberttoyonaga
Copy link
Collaborator

@roberttoyonaga roberttoyonaga commented Sep 29, 2025

The JFR performance tests compare performance with JFR to an app built without JFR included at build time. The performance scoring is done like this:

(value from app with JFR - value from app without JFR) / value form app without JFR.

So the thresholds are not absolute values but are the limit on the difference in performance allowed between the with JFR and without JFR builds. I've change the logging text better reflect the intent. Please have a look when you have time. Thank you!

@roberttoyonaga roberttoyonaga marked this pull request as ready for review September 30, 2025 00:00
@jerboaa
Copy link
Collaborator

jerboaa commented Sep 30, 2025

CI failures are:

Error:  Failures: 
Error:    PerfCheckTest.testQuarkusFullMicroProfile:538 build-and-run.log log should not contain error or warning lines that are not whitelisted. See /home/runner/work/mandrel-integration-tests/mandrel-integration-tests/ts/testsuite/target/archived-logs/org.graalvm.tests.integration.PerfCheckTest/testQuarkusFullMicroProfile/build-and-run.log and check these offending 2 lines: 
event syntax error: 'topdown-retiring/metric-id=topdown!1retiring/,TOPDOWN.SL..'
Initial error: ==> expected: <true> but was: <false>
Error:    PerfCheckTest.testQuarkusJSONParseOnce:263 build-and-run.log log should not contain error or warning lines that are not whitelisted. See /home/runner/work/mandrel-integration-tests/mandrel-integration-tests/ts/testsuite/target/archived-logs/org.graalvm.tests.integration.PerfCheckTest/testQuarkusJSONParseOnce/build-and-run.log and check these offending 2 lines: 
event syntax error: 'topdown-retiring/metric-id=topdown!1retiring/,TOPDOWN.SL..'
Initial error: ==> expected: <true> but was: <false>
Error:    PerfCheckTest.testQuarkusJSON:400 build-and-run.log log should not contain error or warning lines that are not whitelisted. See /home/runner/work/mandrel-integration-tests/mandrel-integration-tests/ts/testsuite/target/archived-logs/org.graalvm.tests.integration.PerfCheckTest/testQuarkusJSON/build-and-run.log and check these offending 2 lines: 
event syntax error: 'topdown-retiring/metric-id=topdown!1retiring/,TOPDOWN.SL..'
Initial error: ==> expected: <true> but was: <false>
[INFO] 
Error:  Tests run: 26, Failures: 3, Errors: 0, Skipped: 4

Which look like #372

@jerboaa jerboaa requested a review from Karm September 30, 2025 09:20
@Karm
Copy link
Owner

Karm commented Oct 1, 2025

GitHub CI does not check these, so lemme run on Jenkins pls...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants