Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register form validation #108

Merged
merged 23 commits into from
Dec 8, 2023
Merged

Register form validation #108

merged 23 commits into from
Dec 8, 2023

Conversation

gf-rog
Copy link
Collaborator

@gf-rog gf-rog commented Dec 6, 2023

No description provided.

Copy link
Collaborator

@JANKROL123 JANKROL123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

Copy link
Owner

@Karol-2 Karol-2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, two little things:

  1. In the Country field you cannot enter "USA" or any longer codes, so maybe change it so it accepts strings with length >=2 and with a first letter being uppercase, if it's possible
  2. In the Photo field can you change it so it accepts only image formats, like .jpg, .png and so on. And with limited size (maybe up to 5MB or less)

Apart from that, works perfectly 👍🏻.

@gf-rog
Copy link
Collaborator Author

gf-rog commented Dec 7, 2023

  1. My thought was that we could add a proper country select box when we had time but I'll change the input box to uppercase. When it comes to country code length, there are two main standards: two-letter and three-letter. Poland can be either PL or POL and the USA can be either US or USA. I chose the two-letter standard
  2. I'll fix it

Copy link
Owner

@Karol-2 Karol-2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Karol-2 Karol-2 merged commit bfbae28 into dev Dec 8, 2023
1 check failed
@Karol-2 Karol-2 deleted the login-register branch December 30, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants