Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meetings fix + some refactoring #130

Merged
merged 65 commits into from
Jan 14, 2024
Merged

Meetings fix + some refactoring #130

merged 65 commits into from
Jan 14, 2024

Conversation

gf-rog
Copy link
Collaborator

@gf-rog gf-rog commented Jan 13, 2024

Meetings are stored in the database as nodes ((u:User)-[:IS_IN_MEETING]->(m:Meeting)).
Meetings are first created using the "Create a meeting" button and then a friend can join it by clicking the camera button in the friends list.
You can't join if there's no meeting created or you're not a friend of the user (not tested).
The meetings are still unstable as ever...

Sockets are stored as nodes instead of attributes ((u:User)-[:CONNECTED_TO]->(s:Socket)).
They are created when a user is logged in and removed when the browser tab is closed.
Video call data is shared only to users which are in a meeting with a user by using socket rooms.

Chat messages are sent to all users' devices if the page is open on any of them.
The chat box scrolls down to show the newest message.

Copy link
Collaborator

@Piterson25 Piterson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bro is a legend 🗿

@Karol-2
Copy link
Owner

Karol-2 commented Jan 13, 2024

A little problem:
When you create a meeting and join it, there is no way to leave. You can go to the search page, but if you try to go to a profile or friends you are still stuck in a meeting. Then the only way is to log out or edit the URL, which is not fun.

Copy link
Collaborator

@JANKROL123 JANKROL123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@gf-rog
Copy link
Collaborator Author

gf-rog commented Jan 14, 2024

A little problem: When you create a meeting and join it, there is no way to leave. You can go to the search page, but if you try to go to a profile or friends you are still stuck in a meeting. Then the only way is to log out or edit the URL, which is not fun.

I agree, I'll fix it quickly

Copy link
Owner

@Karol-2 Karol-2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@Karol-2 Karol-2 merged commit a9e196d into dev Jan 14, 2024
1 check passed
@Karol-2 Karol-2 deleted the meetings-fix branch February 26, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants