Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propositions #144

Merged
merged 11 commits into from
Feb 28, 2024
Merged

Propositions #144

merged 11 commits into from
Feb 28, 2024

Conversation

Karol-2
Copy link
Owner

@Karol-2 Karol-2 commented Feb 27, 2024

I have too much free time, so I added a long-awaited feature - friend suggestions.

Main changes:

  • Add Friend suggestions - friends of your friends that aren't your friends.
  • Add Paginator - to improve the readability of long lists.
  • Move code for displaying friends to a separate component - Friend.
  • Add Paginator for different features - for search (5 per page), for suggestions (3 pp) and friend list (5 pp).

suggestion

Created with help of this little fella:

20240227_121559

@Karol-2 Karol-2 self-assigned this Feb 27, 2024
This was linked to issues Feb 27, 2024
Copy link
Collaborator

@gf-rog gf-rog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admire your willpower to start working so quickly.
I've noticed a few typos but I'll let them pass.
Please format the code. I should fix the workflow to automatically format files.
Nice kitty. Mine unfortunately doesn't help me code...
cat

@gf-rog
Copy link
Collaborator

gf-rog commented Feb 27, 2024

I forgot to mention - paging should be done in the backend since you shouldn't send a million users every time someone wants to add a friend. I could fix it in the future

Copy link
Collaborator

@Piterson25 Piterson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works! 😊
obraz

Copy link
Collaborator

@JANKROL123 JANKROL123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so good

@JANKROL123 JANKROL123 merged commit 0a6e9a6 into dev Feb 28, 2024
1 check passed
@Karol-2 Karol-2 deleted the propositions branch March 2, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination for friends, requests and search Friend Propositions
4 participants