Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user login #97

Merged
merged 30 commits into from
Nov 22, 2023
Merged

Add user login #97

merged 30 commits into from
Nov 22, 2023

Conversation

gf-rog
Copy link
Collaborator

@gf-rog gf-rog commented Nov 22, 2023

No description provided.

Copy link
Collaborator

@Piterson25 Piterson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thorium_djvGP4OhUE

I'm Piterson and I'll approve this PR 🚨

Copy link
Owner

@Karol-2 Karol-2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! There are a few minor issues:

  1. Make "types" folder and put those types there from authRoute.ts in a seperate file.

image

  1. Do it also with types from usresRoute.ts
    image

  2. Can you make that after a successful login it redirects to /messages?

@gf-rog
Copy link
Collaborator Author

gf-rog commented Nov 22, 2023

Sure!

Copy link
Owner

@Karol-2 Karol-2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@Karol-2 Karol-2 merged commit bd10058 into dev Nov 22, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants