Update golangci-lint to v1.57

.golangci.yml

@@ -2,9 +2,6 @@
 
 run:
   timeout: 1m
-  skip-dirs:
-    - .github
-    - .git
   allow-parallel-runners: true
 
 output:
@@ -13,8 +10,6 @@ output:
 linters-settings:
   wsl:
     allow-assign-and-anything: true
-  govet:
-    check-shadowing: true
   godot:
     scope: declarations
     capital: true
@@ -71,8 +66,12 @@ linters: # All available linters list: <https://golangci-lint.run/usage/linters/
     - unparam # Reports unused function parameters
     - unused # Checks Go code for unused constants, variables, functions and types
     - whitespace # Tool for detection of leading and trailing whitespace
+    - shadow
 
 issues:
+  exclude-dirs:
+    - .github
+    - .git
   exclude-rules:
     - path: _test\.go
       linters:

plugin.go

@@ -412,9 +412,9 @@ func (p *Plugin) PushBatch(ctx context.Context, j []jobsApi.Message) error {
 		ctxPush, cancel := context.WithTimeout(ctx, time.Second*time.Duration(p.cfg.Timeout))
 		err := d.(jobsApi.Driver).Push(ctxPush, j[i])
 		if err != nil {
+			cancel()
 			p.metrics.CountPushErr()
 			p.log.Error("job push batch error", zap.String("ID", j[i].ID()), zap.String("pipeline", ppl.Name()), zap.String("driver", ppl.Driver()), zap.Time("start", start), zap.Int64("elapsed", time.Since(start).Milliseconds()), zap.Error(err))
-			cancel()
 			return errors.E(op, err)
 		}