Fixes #37151 - Add --force flag to content overrides#973
Closed
chris1984 wants to merge 1 commit intoKatello:mainfrom
Closed
Fixes #37151 - Add --force flag to content overrides#973chris1984 wants to merge 1 commit intoKatello:mainfrom
chris1984 wants to merge 1 commit intoKatello:mainfrom
Conversation
We only support enabled as a value on content overrides, adding a flag that makes the user add --force for anything other than enabled. Increased the line length to 150 from discussions with Quinn on my last PR since Katello is at 200.
chris1984
force-pushed
the
content-overrides
branch
from
e10fdf5 to
739d891
Compare
jeremylenz
reviewed
Dec 3, 2024
| assert_cmd(expected_result, result) | ||
| end | ||
|
|
||
| it "attaches a content label with value other than enabled without --force" do |
Member
There was a problem hiding this comment.
No it doesn't.
Suggested change
| it "attaches a content label with value other than enabled without --force" do | |
| it "does not attach a content label with value other than enabled without --force" do |
Member
There was a problem hiding this comment.
nit: All the times it says "attach a content label" in this file, we actually mean "attach a content override."
Member
Author
|
Can't reopen pr thanks GH for closing it 😠 #977 is the new one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
--forceoption and validating we error out with invalid usage if the flag is not present.Considerations taken when implementing this change?
What are the testing steps for this pull request?
hammer host subscription content-override --override-name food --value disable --content-label test --host-id 3--forceflag--forceand it should go throughhammer activation-key content-override --override-name food --value disable --content-label test --id 1I am not sure how content labels work for activation keys since I getContent label(s) "test" were not found in the Organization "Default Organization"but the pr still works to require the user to pass in--force