Fixes #31862 - eslint error in Tasks/helpers.js #9159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #31862 |
parthaa
approved these changes
Feb 11, 2021
|
I mean you could consider disabling the rule until we figure out a solution. It's just really hard to tell the difference between "looping over a list of error objects" and "waiting for the results of an async callback". We're having a discussion about it here eslint-community/eslint-plugin-promise#212 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the recent release of eslint-plugin-promise broke us due to this change eslint-community/eslint-plugin-promise#202
While I think it could be a bug there, we can easily fix it to keep our builds passing and PRs merging, so that's what this PR does :)