check for valid timezone and add by-group in migration

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 1.0.1 to 1.0.2
+
+- include check for valid timezones and take user timezone if lockdown-timezone is invalid
+- update migration SQL to include additional group to support updates also on SQL option "only_full_group_by"
+
 ## 1.0.0 to 1.0.1
 
 - performance updates

Migrations/Version20231227114025.php

@@ -32,7 +32,7 @@ public function up(Schema $schema): void
                 SELECT ap.user_id, ap.start_date, ap.end_date, SUM(t.duration) AS dur_sum
                   FROM kimai2_ext_approval as ap, kimai2_timesheet AS t
                   WHERE ap.user_id = t.user AND t.start_time >= ap.start_date AND DATE_FORMAT(t.end_time,"%Y-%m-%d") <= ap.end_date
-                  GROUP BY ap.user_id, ap.start_date
+                  GROUP BY ap.user_id, ap.start_date, ap.end_date
               ) AS tm ON app.user_id = tm.user_id AND app.start_date = tm.start_date
               SET app.actual_duration = tm.dur_sum');
     }

Repository/LockdownRepository.php

@@ -68,7 +68,13 @@ private function updatePreference(User $user, string $preferenceName, string $va
      */
     private function getOldestNotSubmittedDate(array $allWeeks, User $user): DateTime
     {
-        $timezone = new DateTimeZone($user->getPreferenceValue('timezone'));
+        $timezoneValue = $user->getPreferenceValue('timezone');
+        $validTimezones = DateTimeZone::listIdentifiers();
+        if (!in_array($timezoneValue, $validTimezones)) {
+            $timezoneValue = $user->getTimezone();
+        } 
+
+        $timezone = new DateTimeZone($timezoneValue);
 
         foreach ($allWeeks as $week) {
             if ($week['status'] === 'not_submitted') {