Kimai v2 bug fixes #24
Conversation
| @@ -35,7 +35,7 @@ | |||
| <td> | |||
| {% set deleteLinkPath = path('delete_overtime_history', {'entryId': entry.id }) %} | |||
| <button type="button" class="btn btn-sm btn-warning closeModal" | |||
| onclick="$('#deniedLink').attr('href', '{{ deleteLinkPath }}');"> | |||
| onclick="window.location.href='{{deleteLinkPath}}'"> | |||
There was a problem hiding this comment.
I don't know if this change is related with jQuery that was removed from Kimai.
If yes, your change is a good approach, but have a lot of places using jQuery.
I made this workaround that maybe fixed all problems related as jQuery
bee83f9
I know that isn't the best because is a request to an external package, but was the most simple and fast solution that I found.
There was a problem hiding this comment.
Either works, but I agree that it should be standardized throughout. I went with this method as it was already used in a few other places throughout the codebase and didn't require any external dependencies.
|
I did a small pause with my contributions because I need to dedicate more time to other tasks at LibreSign project but would be create issues before start the development. This is a tip to me too because if I had made this, it would prevent possible rework. |
You're correct, I should have opened issues before contributing. I'll be sure to be more diligent in the future. As it stands these are mostly minor bug fixes, so hopefully this won't cause too much issue! Thanks for your feedback! |
KatjaGlassConsulting
merged commit 2c0ea51
into
KatjaGlassConsulting:kimai_v2_update
Vitor and I seem to have been working on this migration at the same time, but he beat me to it by a few hours!
I'll continue to contribute bug fixes as I find them - for now here are a few mostly related to non-functional buttons and a couple of runtime errors