EventManager: Alow callable as listeners [Closes #57] #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -171,7 +171,7 @@ public function hasListeners($eventName) | |||
| * Adds an event listener that listens on the specified events. | |||
| * | |||
| * @param string|array $events The event(s) to listen on. | |||
| * @param Doctrine\Common\EventSubscriber|array $subscriber The listener object. | |||
| * @param Doctrine\Common\EventSubscriber|array|callable $subscriber The listener object. | |||
There was a problem hiding this comment.
As @vojtech-dobes said somewhere, Doctrine\Common\EventSubscriber does not exist.
The dependency is missing?
There was a problem hiding this comment.
It exists, just not in this repo :)
|
Wow, great job! I'm gonna try real hard to look into this soon. |
|
👍 For this, I'd love to use |
| foreach ($this->listeners as $event => $prioritized) { | ||
| foreach ($prioritized as $listeners) { | ||
| foreach ($listeners as $listener) { | ||
| if ($listener == $subscriber) { |
|
This seems good enough for me: 69806d1...b6fc86b |
|
Thank you! And sorry for not getting to it sooner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57
In some cases I would like use dynamic listeners or use callbacks as listeners.
It was not possible before and this PR adds the functionality requested in #57.
In cases when I would like use callbacks almost everytime is it possible to create Subscriber which supplies the functionality. So I'm not 100% sure that the feature is really needed.
Does anybody has a specific use case when callback or __call methods are better than "real classes with real methods"?