commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/vimpostor/tera/commit/9479c2801093d856811fda3660e50fb8be9d3f5c/hovercard" href="https://github.com/vimpostor/tera/commit/9479c2801093d856811fda3660e50fb8be9d3f5c">9479c28. Since that commit, providing an invalid glob to tera will make it fail to create an instance, first (in that commit) by making it panic and since 1f95878 by making it return an error. While returning an error is not entirely unlogical, it doesn't match what most languages do with invalid globs. - Bash will by default return an empty set on invalid globs, as the `failglob` option is off by default - Python will likewise return the empty set instead of throwing an exception, when doing something like `glob.glob("/dev/null/*")` - Rust's `globwalk` will also not error, but return an empty set In fact, we use globwalk in tera and the only reason we panic is by accident, because `std::fs::canonicalize()` checks the path. It is better to match other language's glob behaviour, therefore we resort back to the original path if `canonicalize()` fails. We should especially restore the previous behaviour, as this caused a lot of regressions already, including in zola. Fixes getzola/zola#2150 ref: Keats#819 ref: Keats#820 ref: Keats#799

Commits

Commits on Apr 10, 2023

Return empty list on invalid globs