Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation on demand #15

Merged
merged 81 commits into from
Jan 3, 2024
Merged

Compilation on demand #15

merged 81 commits into from
Jan 3, 2024

Conversation

Keluaa
Copy link
Owner

@Keluaa Keluaa commented Jun 20, 2023

No description provided.

Keluaa added 16 commits May 26, 2023 11:32
@Keluaa
WIP
35d0fe9
@Keluaa
WIP space name filtering
1fa82e3
@Keluaa
WIP: filter memory spaces and apply on copy.cpp
f1ab26b
@Keluaa
Small check for valid Kokkos version + support for VersionNumber
2bbbbd4
@Keluaa
Renamed KokkosWrapper module to Wrapper
f3791b6
@Keluaa
Completed compilation on demand. Moved Idx to Spaces.
dbf3c28
@Keluaa
Removed configuration options for views. Renamed load_or_compile to…
6582914 
… `compile_and_load`
@Keluaa
Renamed COMPILED_EXEC_SPACES and COMPILED_EXEC_SPACES to `ENABLED…
3768df6 
…_*_SPACES`
@Keluaa
Updated tests
15db3f7
@Keluaa
Control on which views tests are done, plus a few more tests.
a7cbcb7
@Keluaa
Moved layouts to their own file
7122456
@Keluaa
Updated docs
d4ef056
@Keluaa
Compilation lock
6d90966
@Keluaa
Version 0.5.0. Cleanup
9e2e4f6
@Keluaa
Merge branch 'main' into compilation_on_demand
e93e9a9 
# Conflicts:
#	Project.toml
#	lib/kokkos_wrapper/CMakeLists.txt
#	src/configuration.jl
#	src/kokkos_wrapper.jl
#	test/views.jl
#	test/views_gpu.jl
@Keluaa
Small fix
be98300
@codecov
Copy link

codecov bot commented Jun 20, 2023 •
edited
Loading

Codecov Report

Attention: 80 lines in your changes are missing coverage. Please review.

Comparison is base (2037c8c) 82.94% compared to head (17ed7e8) 82.27%.

Files Patch % Lines
ext/KokkosAMDGPU.jl 0.00% 24 Missing ⚠️
src/views.jl 84.39% 22 Missing ⚠️
src/utils.jl 80.35% 11 Missing ⚠️
src/kokkos_project.jl 70.37% 8 Missing ⚠️
src/kokkos_wrapper.jl 85.00% 6 Missing ⚠️
src/configuration.jl 57.14% 3 Missing ⚠️
src/spaces.jl 66.66% 3 Missing ⚠️
src/dynamic_compilation.jl 98.13% 2 Missing ⚠️
src/layouts.jl 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   82.94%   82.27%   -0.68%     
==========================================
  Files          11       14       +3     
  Lines         780     1021     +241     
==========================================
+ Hits          647      840     +193     
- Misses        133      181      +48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Keluaa added 13 commits June 20, 2023 16:03
@Keluaa
Compile create_mirror_* result view type. Deep copy tests for errors.
d314615
@Keluaa
Compile create_mirror_* result view type. Deep copy tests for errors.
43eb444
@Keluaa
Merge remote-tracking branch 'origin/compilation_on_demand' into comp…
80fa190 
…ilation_on_demand

# Conflicts:
#	lib/kokkos_wrapper/views.cpp
#	src/views.jl
@Keluaa
Added cxx_type_name
268cc68
@Keluaa
Fixes to create_mirror[_view]. Fixes to cxx_type_name.
9e185a5
@Keluaa
Deep copy CI debug
8b08211
@Keluaa
Revert "Deep copy CI debug"
9a09223 
This reverts commit 8b08211.
@Keluaa
Circumvent JuliaInterop/CxxWrap.jl#363
491fed9
@Keluaa
Update README.md
ad6305b
@Keluaa
Greatly reduced test time for GPUs.
cb22386 
[skip ci]
@Keluaa
Fixed Kokkos.deep_copy(exec, dest, src)
7e0628f
@Keluaa
Replace 'compiled' with 'enabled'
8164455
@Keluaa
Always generate a deep_copy method, but throw a runtime error if `!is…
2cc6c4c 
…_deep_copyable`

[skip ci]
Keluaa added 28 commits June 29, 2023 09:28
@Keluaa
HIP fixes
58dda2d
@Keluaa
Fixed occasional wrong definitions of methods. Cleanup.
18e2163
@Keluaa
Better MPI testing. TEST_CMAKE_OPTIONS
ec37366
@Keluaa
Small test fix
da6a131
@Keluaa
Run CI every week
8274199
@Keluaa
Rerun CMake when it fails to reconfigure itself
b680778
@Keluaa
Handle inaccessible views when printing
9599918
@Keluaa
Update docs
46c5974
@Keluaa
Add known issues section
c615f99
@Keluaa
ROCArray wrapping fixes. Cleanup.
dda9e92
@Keluaa
Added BackendFunctions.memory_info.
da66be9
@Keluaa
Added Wrapper.clean_cmake_files.
bded4aa
@Keluaa
RTLD_GLOBAL flag on the wrapper lib
7511b28
@Keluaa
Fix unsafe_wrap with ROCArray. Update compat.
6a45cd3
@Keluaa
Support latest for local Kokkos versions.
2fa36b6
@Keluaa
Silent view printing in tests
2096871
@Keluaa
Use only Julia 1.9
c035c0f
@Keluaa
Replace ✔️ with ✅ [skip ci]
fd22fea
@Keluaa
Minor fixes. Load all extensions when making documentation.
0ecdcd6
@Keluaa
AMDGPU v0.7 support: properly keep ownership of the GPU memory.
8004c1c
@Keluaa
Update CxxWrap lib compat
f0d7b2e
@Keluaa
Precisions about lock files
5a0798a
@Keluaa
Update compat. Fix unsafe_wrap for AMDGPU.jl. Small fixes for tests.
b00ab9d
@Keluaa
Add docs from extensions.
916b255
@Keluaa
Merge branch 'compilation_on_demand' of https://github.com/Keluaa/Kok…
a0de284 
…kos.jl into compilation_on_demand
@Keluaa
Merge remote-tracking branch 'origin/compilation_on_demand' into comp…
0119cf3 
…ilation_on_demand

# Conflicts:
#	Project.toml
#	ext/KokkosAMDGPU.jl
@Keluaa
Make all spaces non-mirrored types for compat with Kokkos 4.2+
91956d6
@Keluaa
CI for latest Julia version. Use Documenter 1.0.
17ed7e8
@Keluaa Keluaa merged commit 236b30d into main Jan 3, 2024
6 of 8 checks passed
@Keluaa Keluaa deleted the compilation_on_demand branch January 3, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Keluaa