Skip to content

Conversation

msteknoadam
Copy link

With this feature, bot will update it's status as Watching x Servers! where x will be number of server that this bot is online on. This feature is made regarding #5 .

@KenjiE20
Copy link
Owner

KenjiE20 commented Oct 4, 2019

Thanks for the PR.

This is a nice start on this feature, I've had ideas rattling around for a while for this (rotating status lines), so this may not be the ideal location for this code, more likely would be from it's own module file, or a named function elsewhere that can be scheduled and remotely called on bigger changes.

The current code is would only track guilds the bot is in, rather than the amount of OpenTTD servers the bot is connected to.

Lastly I'd prefer PRs limit commits to changes directly related (this PR has a lot of unrelated indent and format changes)

@msteknoadam
Copy link
Author

msteknoadam commented Oct 5, 2019

The reason this PR has a "added prettier options" commit is that I have prettier installed and if I would work with the defaults, I would have changed every file's indents but I set them to how you used so there shouldn't be any problem with that in my opinion(and since I did this for Hacktoberfest event, I didn't want to look like I'm adding tons of PRs just for 1 commits, tho I had to go like that with the README change since it's a total different change so should be able to committed seperately.) I'll be taking a look to make it use the current online OpenTTD server amount when I have some free time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants