#245 target former urls instead of page urls paths

Kentico · Sep 19, 2024 · cc712c1 · cc712c1
1 parent 9531e7c
commit cc712c1
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 39 deletions.
diff --git a/KVA/Migration.Toolkit.Source/Handlers/MigratePagesCommandHandler.cs b/KVA/Migration.Toolkit.Source/Handlers/MigratePagesCommandHandler.cs
@@ -4,6 +4,7 @@
 using CMS.ContentEngine;
 using CMS.ContentEngine.Internal;
 using CMS.Core;
+using CMS.Core.Internal;
 using CMS.DataEngine;
 using CMS.DataEngine.Query;
 using CMS.Websites;
@@ -366,7 +367,7 @@ private async Task MigratePageUrlPaths(Guid webSiteChannelGuid, Guid languageGui
             }
             else if (GetCmsClass(ksTree.NodeClassID) is { } cmsClass && string.IsNullOrWhiteSpace(cmsClass.ClassURLPattern))
             {
-                logger.LogError("Cannot migrate url for document '{DocumentID}' / node '{NodeID}', class {ClassName} has no url pattern set - default fallback will be used.", ksDocument?.DocumentID, ksTree.NodeID, cmsClass.ClassName);
+                logger.LogWarning("Cannot migrate url for document '{DocumentID}' / node '{NodeID}', class {ClassName} has no url pattern set - cannot migrate to former url.", ksDocument?.DocumentID, ksTree.NodeID, cmsClass.ClassName);
             }
             else if (sourceInstanceContext.GetNodeUrls(ksTree.NodeID, site.SiteName) is not { Count: > 0 } pageModels)
             {
@@ -383,44 +384,18 @@ private async Task MigratePageUrlPaths(Guid webSiteChannelGuid, Guid languageGui
             else
             {
                 string patchedUrl = pageModel.CultureUrl.TrimStart(['~']).TrimStart(['/']);
-
-                foreach (var contentItemCommonDataInfo in contentItemCommonDataInfos.Where(x => x.ContentItemCommonDataContentLanguageID == languageInfo.ContentLanguageID))
+                string urlHash = modelFacade.HashPath(patchedUrl);
+                var webPageFormerUrlPathInfo = new WebPageFormerUrlPathInfo
                 {
-                    logger.LogTrace("Page url path common data info: CIID={ContentItemId} CLID={Language} ID={Id} IPC", contentItemCommonDataInfo.ContentItemCommonDataContentItemID, contentItemCommonDataInfo.ContentItemCommonDataContentLanguageID, contentItemCommonDataInfo.ContentItemCommonDataID);
-
-                    // decision - if change in url occurs in source instance, it is desirable to overwrite migrated one.
-                    var webPageUrlPathGuid = contentItemCommonDataInfo.ContentItemCommonDataVersionStatus == VersionStatus.Draft
-                        ? GuidHelper.CreateWebPageUrlPathGuid($"{ksDocument!.DocumentGUID}|{documentCulture}|{ksTree.NodeAliasPath}|DRAFT|{ksTree.NodeID}")
-                        : GuidHelper.CreateWebPageUrlPathGuid($"{ksDocument!.DocumentGUID}|{documentCulture}|{ksTree.NodeAliasPath}|{ksTree.NodeID}");
-
-                    string urlHash = modelFacade.HashPath(patchedUrl);
-
-                    var webPageUrlPath = new WebPageUrlPathModel
-                    {
-                        WebPageUrlPathGUID = webPageUrlPathGuid,
-                        WebPageUrlPath = patchedUrl,
-                        WebPageUrlPathHash = urlHash,
-                        WebPageUrlPathWebPageItemGuid = webPageItemInfo.WebPageItemGUID,
-                        WebPageUrlPathWebsiteChannelGuid = webSiteChannelGuid,
-                        WebPageUrlPathContentLanguageGuid = languageGuid,
-                        WebPageUrlPathIsLatest = contentItemCommonDataInfo.ContentItemCommonDataIsLatest,
-                        WebPageUrlPathIsDraft = contentItemCommonDataInfo.ContentItemCommonDataVersionStatus switch
-                        {
-                            VersionStatus.InitialDraft => false,
-                            VersionStatus.Draft => true,
-                            VersionStatus.Published => false,
-                            VersionStatus.Unpublished => false,
-                            _ => throw new ArgumentOutOfRangeException()
-                        }
-                    };
-
-                    CheckPathAlreadyExists(webPageUrlPath, languageInfo, webSiteChannel, webPageItemInfo.WebPageItemID);
-
-                    var importResult = await importer.ImportAsync(webPageUrlPath);
-
-                    LogImportResult(importResult);
-                }
-
+                    WebPageFormerUrlPath = patchedUrl,
+                    WebPageFormerUrlPathHash = urlHash,
+                    WebPageFormerUrlPathWebPageItemID = webPageItemInfo.WebPageItemID,
+                    WebPageFormerUrlPathWebsiteChannelID = webSiteChannel.WebsiteChannelID,
+                    WebPageFormerUrlPathContentLanguageID = languageInfo.ContentLanguageID,
+                    WebPageFormerUrlPathLastModified = Service.Resolve<IDateTimeNowService>().GetDateTimeNow()
+                };
+                WebPageFormerUrlPathInfo.Provider.Set(webPageFormerUrlPathInfo);
+                logger.LogEntitySetAction(true, webPageItemInfo);
                 return;
             }
         }

diff --git a/KVA/Migration.Toolkit.Source/Helpers/Printer.cs b/KVA/Migration.Toolkit.Source/Helpers/Printer.cs
@@ -4,7 +4,7 @@
 using CMS.MediaLibrary;
 using CMS.Membership;
 using CMS.Modules;
-
+using CMS.Websites;
 using Migration.Toolkit.Common.Helpers;
 using Migration.Toolkit.Common.Services;
 using Migration.Toolkit.KXP.Models;
@@ -61,6 +61,7 @@ string FormatModel(string inner) => printType
             UserInfo item => FormatModel($"ID={item.UserID}, Guid={item.UserGUID} Name={item.UserName}"),
             RoleInfo item => FormatModel($"ID={item.RoleID}, Guid={item.RoleGUID} Name={item.RoleName}"),
             MemberInfo item => FormatModel($"ID={item.MemberID}, Guid={item.MemberGuid} Name={item.MemberName}"),
+            WebPageFormerUrlPathInfo item => FormatModel($"ID={item.WebPageFormerUrlPathID}, Guid=N/A Name={item.WebPageFormerUrlPath}"),
 
             CmsForm item => FormatModel($"ID={item.FormId}, GUID={item.FormGuid}, Name={item.FormName}"),
             CmsUser item => FormatModel($"ID={item.UserId}, GUID={item.UserGuid}, Name={item.UserName}"),