Optimize code #14
Merged
Optimize code #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
AmarokIce
approved these changes
Sep 21, 2024
entrypoint/common/src/main/java/band/kessoku/lib/entrypoint/impl/KessokuMetadata.java
Outdated
Show resolved
Hide resolved
| ((MapNode) node).forEach(pair -> { | ||
| // normalize value | ||
| final JsonNode<?> rawValue = pair.getValue(); | ||
| final List<EntrypointMetadata> entrypointMetadataList = switch (rawValue.getType()) { |
There was a problem hiding this comment.
[待办] 建议分割为小块的私有方法处理，而不是堆叠嵌套。这样的嵌套太复杂了。
Oganesson897
approved these changes
Sep 21, 2024
TexBlock
approved these changes
Sep 21, 2024
|
不是你们怎么都approve了 我还没写完呢 |
嘛？ |
你推送一段我们 approve 一段阿（？） |
TexBlock
reviewed
Oct 4, 2024
TexBlock
approved these changes
Oct 4, 2024
|
@AmarokIce 你怎么还没动静 💢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.