Add JIRA info for security team. #5
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipowell
commented
Oct 17, 2024
| "LC": _ISSUETYPE_ID_SUPPORT, | ||
| "MPP": _ISSUETYPE_ID_SUPPORT, | ||
| "LP": _ISSUETYPE_ID_SUPPORT, | ||
| "SEC": _ISSUETYPE_ID_SUPPORT, |
There was a problem hiding this comment.
The comment above these says it's the "default" issue type, but it looks like any new issues will just get filed of this type, so I think @Khan/security gets to pick.
There was a problem hiding this comment.
"Support" seems better than "Bug" for our world as a sane default.
ipowell
requested review from
drosile,
gsamuelhays,
ioanacrant and
jeremyspangler
gsamuelhays
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add mapping to Security JIRA project so tickets can be filed.
Issue: https://khanacademy.atlassian.net/browse/SEC-19
Test plan:
I'm working on it. I'll update some tests in
alertlib_testto send to the Security project andinspect the logs to make sure those look okay. I'm not able to resolve these dependencies yet so I'm
tinkering with that at the moment. I'll update this once I can verify.