Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--save no longer needed #343

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

--save no longer needed #343

wants to merge 1 commit into from

Conversation

JoeCortopassi
Copy link

--save is on by default as of npm 5, so npm install aphrodite is functionally equivalent to npm install --save aphrodite now

`--save` is on by default as of [npm 5](https://blog.npmjs.org/post/161081169345/v500), so `npm install aphrodite` is functionally equivalent to `npm install --save aphrodite` now
@khanbot
Copy link

khanbot commented Oct 1, 2018

Hey @JoeCortopassi,

Thanks for the PR! Mind signing our Contributor License Agreement?

When you've done so, go ahead and comment [clabot:check] and I'll check again.

Yours truly,
khanbot

@JoeCortopassi
Copy link
Author

[clabot:check]

@khanbot
Copy link

khanbot commented Oct 1, 2018

Hey @JoeCortopassi,

Thanks for the PR! Mind signing our Contributor License Agreement?

When you've done so, go ahead and comment [clabot:check] and I'll check again.

Yours truly,
khanbot

@JoeCortopassi
Copy link
Author

[clabot:check]

@khanbot
Copy link

khanbot commented Oct 6, 2018

CLA signature looks good 👍

@kevinbarabash
Copy link
Contributor

I didn't realize this. npm 5 was released in May 2017 which is a while. I guess if people have issues we can always add a note about earlier npm versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants