Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I use
import {css} from 'aphrodite/no-important'
in a ES module file, bundle tools like Rollup will resolveaphrodite/no-important
tonode_modules/aphrodite/no-important.js
and thennode_modules/aphrodite/lib/no-important.js
which is not a ES module. To make things worse,rollup-plugin-commonjs
cannot resolve named import (import {X} from 'x'
) for CommonJS modules.A workaround is to use
import {css} from 'aphrodite/es/no-important'
. However this doesn't work for 'universal' code because ES module cannot be resolved in Node environment without being transpiled.This change will let module resolver find
package.json
file innode_modules/aphrodite/no-important
directory.