Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve npmignore #398

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Brianzchen
Copy link
Contributor

Update .npmignore file to not publish files and dirs that aren't used by consumers. This simplified the distributed binaries but the main motivation for this change is that .flowconfig is included when aphrodite is published. Which if I browse the files within node_modules, flow server will crash because it detects multiple upstream flow configs.

@lencioni @jlfwong

@alii
Copy link

alii commented Apr 21, 2021

Some people will not use npm to install the package (e.g. install from GitHub url) – would that still work if src is ignored?

@Brianzchen
Copy link
Contributor Author

People shouldn't really be using src folder directly. I mean they can but general expectation is you import via the main export which points to the built lib + /no-important in aphrodites case.

But if there's a valid use case, happy to exclude and continue to ship src

@alii
Copy link

alii commented Apr 21, 2021

I'm really not sure I am not knowledgable enough on the topic, was purely a question if it would still work

@Brianzchen
Copy link
Contributor Author

I'm really not sure I am not knowledgable enough on the topic, was purely a question if it would still work

Yep should still work. npmignore is just for files to ignore during the npm publish process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants