-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix-reviewers-lilli] testing #91
Open
lillialexis
wants to merge
8
commits into
main
Choose a base branch
from
fix-reviewers-lilli
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Nov 12, 2024
-
Add labels in a more principled way.
Before, I was just munging the label to the name, so I wouldn't have to change a lot of code. This didn't work because the name was used in places where the code needs it to actually be a name (e.g. when telling github what reviewers to add to the PR). So now I store names and labels separately, and just print the label explicitly when emitting the comment text. This also gives me more control over where the label goes; all in all a more maintainable arrangement. Issue: https://khanacademy.atlassian.net/browse/FEI-5970 Test plan: yarn jest
Configuration menu - View commit details
-
Copy full SHA for 2631047 - Browse repository at this point
Copy the full SHA 2631047View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10570dc - Browse repository at this point
Copy the full SHA 10570dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 24a71c0 - Browse repository at this point
Copy the full SHA 24a71c0View commit details
Commits on Nov 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e457f71 - Browse repository at this point
Copy the full SHA e457f71View commit details -
Configuration menu - View commit details
-
Copy full SHA for c336073 - Browse repository at this point
Copy the full SHA c336073View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec2ac60 - Browse repository at this point
Copy the full SHA ec2ac60View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52c0976 - Browse repository at this point
Copy the full SHA 52c0976View commit details
Commits on Nov 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 13c938e - Browse repository at this point
Copy the full SHA 13c938eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.