Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix-reviewers-lilli] testing #91

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Commits on Nov 12, 2024

  1. Add labels in a more principled way.

    Before, I was just munging the label to the name, so I wouldn't have
    to change a lot of code.  This didn't work because the name was used
    in places where the code needs it to actually be a name (e.g. when
    telling github what reviewers to add to the PR).
    
    So now I store names and labels separately, and just print the label
    explicitly when emitting the comment text.  This also gives me more
    control over where the label goes; all in all a more maintainable
    arrangement.
    
    Issue: https://khanacademy.atlassian.net/browse/FEI-5970
    
    Test plan:
    yarn jest
    csilvers committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    2631047 View commit details
    Browse the repository at this point in the history
  2. rebuild dist file

    csilvers committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    10570dc View commit details
    Browse the repository at this point in the history
  3. share a type

    csilvers committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    24a71c0 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Configuration menu
    Copy the full SHA
    e457f71 View commit details
    Browse the repository at this point in the history
  2. [fix-reviewers-lilli] wfs

    lillialexis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    c336073 View commit details
    Browse the repository at this point in the history
  3. [fix-reviewers-lilli] t

    lillialexis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ec2ac60 View commit details
    Browse the repository at this point in the history
  4. [fix-reviewers-lilli] t

    lillialexis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    52c0976 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Configuration menu
    Copy the full SHA
    13c938e View commit details
    Browse the repository at this point in the history