Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackathon 2024 - Biome 1 #1796

Draft
wants to merge 15 commits into
base: feature/hackathon-biome
Choose a base branch
from
Draft

Conversation

jeremywiebe
Copy link
Collaborator

@jeremywiebe jeremywiebe commented Oct 24, 2024

Summary:

This PR introduces a new tool for code formatting and linting (all-in-one) called Biome. It is written in Rust and is significantly faster than ESLint and Prettier. It is a "batteries included" type of tool (with many built-in rules).

I'm going to build a chain of PRs on the feature/hackathon-biome to check everything out.

PRs

The specific pieces of this PR are:

  • yarn add --dev --exact --workspace @biomejs/biome
  • yarn biome init --jsonc
  • Fix error in .editorconfig
  • Initial working biome.jsonc
  • Update repo vscode settings for Biome
  • Change bracketSpacing to match prettier config
  • Turn off organizeImports to start
  • Disable linter to start
  • Ignore data/questions data files
  • Ignore genfiles
  • Ignore source files in vendor/
  • Ignore dist/ directories
  • Configure Biome to handle the various JSONC tsconfig.json files
  • Migrate from // prettier-ignore to // biome-ignore

Issue: --hackathon-2024--

Test plan:

yarn
yarn biome check (there will be errors, but check out the formatting of the errors, etc).

@jeremywiebe jeremywiebe self-assigned this Oct 24, 2024
Copy link
Contributor

github-actions bot commented Oct 24, 2024

Size Change: +74 B (+0.01%)

Total Size: 866 kB

Filename Size Change
packages/perseus-linter/dist/es/index.js 22.2 kB +17 B (+0.08%)
packages/perseus/dist/es/index.js 419 kB +57 B (+0.01%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.8 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 77.7 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 281 kB
packages/perseus/dist/es/strings.js 3.4 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant