-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hackathon 2024 - Biome 1 #1796
Draft
jeremywiebe
wants to merge
15
commits into
feature/hackathon-biome
Choose a base branch
from
jer/biome-1
base: feature/hackathon-biome
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Hackathon 2024 - Biome 1 #1796
+193
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +74 B (+0.01%) Total Size: 866 kB
ℹ️ View Unchanged
|
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR introduces a new tool for code formatting and linting (all-in-one) called Biome. It is written in Rust and is significantly faster than ESLint and Prettier. It is a "batteries included" type of tool (with many built-in rules).
I'm going to build a chain of PRs on the
feature/hackathon-biome
to check everything out.PRs
The specific pieces of this PR are:
yarn add --dev --exact --workspace @biomejs/biome
yarn biome init --jsonc
.editorconfig
biome.jsonc
bracketSpacing
to match prettier configorganizeImports
to startdata/questions
data filesgenfiles
vendor/
dist/
directoriestsconfig.json
files// prettier-ignore
to// biome-ignore
Issue: --hackathon-2024--
Test plan:
yarn
yarn biome check
(there will be errors, but check out the formatting of the errors, etc).