Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Categorizer: Extract validation out of scoring #1862

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Categorizer: Extract validation out of scoring #1862

wants to merge 11 commits into from
+115 −39

Commits on Nov 14, 2024

  1. Split validation tests from scoring tests

    @Myranae
    Myranae committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    e6f0b85 View commit details
    Browse the repository at this point in the history

  2. Put validation logic in own function and call it

    @Myranae
    Myranae committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    4e1f7b2 View commit details
    Browse the repository at this point in the history

  3. Add changeset

    @Myranae
    Myranae committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    e2552af View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Pull values (the answers) out of the validation

    @Myranae
    Myranae committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    52e6aad View commit details
    Browse the repository at this point in the history

  2. Update validationResult to validationError

    @Myranae
    Myranae committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    28766a3 View commit details
    Browse the repository at this point in the history

  3. Add test for null return

    @Myranae
    Myranae committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    27c222e View commit details
    Browse the repository at this point in the history

  4. Simplify validation check

    @Myranae
    Myranae committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    c77806a View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Add validation type

    @Myranae
    Myranae committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    539b8cc View commit details
    Browse the repository at this point in the history

  2. Update validator to use validateData instead of rubric

    @Myranae
    Myranae committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    109df1b View commit details
    Browse the repository at this point in the history

  3. Rename rubric + validation data to scoringData

    @Myranae
    Myranae committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    261fcf1 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Add documentation to validate function

    @Myranae
    Myranae committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    9437cfd View commit details
    Browse the repository at this point in the history