-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable dependabot updates for WB/WS (and group them) #1863
base: main
Are you sure you want to change the base?
Conversation
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (706d132) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1863 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1863 |
Size Change: -93 B (-0.01%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
11f2787
to
a478aa2
Compare
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
groups: | ||
wonder-stuff: | ||
patterns: | ||
- "@khanacademy/wonder-stuff-*" | ||
wonder-blocks: | ||
patterns: | ||
- "@khanacademy/wonder-blocks-*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we filter out certain packages? I'm asking as we have a couple of WB deprecated packages that we usually skip when upgrading webapp (wb-color
and wb-spacing
).
It would be nice if we could skip them programmatically with dependabot so we never see these packages in here, as it would be noisy/counterproductive to have them included.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds perfect, thanks!
…ntally add them back as a dependency at some point (they're deprecated)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! also the Lint rule is super useful (I'm going to replicate it in webapp
). 🚀
Summary:
Juan and I were discussing keeping Perseus dependnecies up to date with webapp (especially WB and WS). This is a trial run to see if Dependabot will help us. It should open up a new PR any time WB or WS packages are released. And all WB or WS packages that received an update should be updated together in the same Perseus PR.
Issue: "none"
Test plan:
I suspect I'll need to land this and monitor it to test. Github action infra is notoriously difficult to test locally.