Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orderer: Extract validation out of scoring #1869

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Orderer: Extract validation out of scoring #1869

wants to merge 11 commits into from
+102 −12

Commits on Nov 15, 2024

  1. Remove usage of underscore

    @Myranae
    Myranae committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    f8bf0cb View commit details
    Browse the repository at this point in the history

  2. Split out validation logic into own function

    @Myranae
    Myranae committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    149e71c View commit details
    Browse the repository at this point in the history

  3. Split out validation tests

    @Myranae
    Myranae committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    b77fec0 View commit details
    Browse the repository at this point in the history

  4. Add changeset

    @Myranae
    Myranae committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    fe14fbb View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into tb/LEMS-2603/orderer-split-out-validation

    @Myranae
    Myranae committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    ca822d6 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Retain test to confirm scoring function can handle invalid validation

    @Myranae
    Myranae committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    d8480f1 View commit details
    Browse the repository at this point in the history

  2. Switch to default export for consistency

    @Myranae
    Myranae committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    bd03247 View commit details
    Browse the repository at this point in the history

  3. Add tests confirming scoring correctly handles validation results

    @Myranae
    Myranae committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    b203d48 View commit details
    Browse the repository at this point in the history

  4. Add comment to validation function

    @Myranae
    Myranae committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    74bf0e6 View commit details
    Browse the repository at this point in the history

  5. Update import syntax

    @Myranae
    Myranae committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    afbe43c View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Fix typo in doc comment

    @Myranae
    Myranae committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    1e6f37f View commit details
    Browse the repository at this point in the history