Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Locked Labels] Count lone unescaped $ as regular dollar signs #1875

Open
wants to merge 6 commits into
base: labels-util-function
Choose a base branch
from

Commits on Nov 16, 2024

  1. [Locked Labels] Count lone unescaped $ as regular dollar signs

    Right now, if you type "$1" into the locked label input, it
    shows up as "undefined1" in the graph TeX.
    
    - Update the parsed content to count a lone unescaped $
      as a regular $.
    
    Issue: https://khanacademy.atlassian.net/browse/LEMS-2591
    
    Test plan:
    `yarn jest packages/perseus/src/widgets/interactive-graphs/utils.test.ts`
    
    Storybook
    - Go to http://localhost:6006/?path=/story/perseuseditor-widgets-interactive-graph--interactive-graph-with-aria-label
    - Create a new locked figure
    - Add a label "$1" and confirm it shows up as "$1" in the preview
    - Play around with different escaped and unescaped dollar signs
      and confirm they work as expected
    nishasy committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    a271489 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Use math only parser

    nishasy committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    3379e89 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7aad8b1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b6be09d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b57fd42 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7827abc View commit details
    Browse the repository at this point in the history