Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorter: Extract validation out of scoring #1876

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Sorter: Extract validation out of scoring #1876

wants to merge 11 commits into from
+118 −12

Commits on Nov 18, 2024

  1. Split out validation logic to new function

    @Myranae
    Myranae committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    2420ea3 View commit details
    Browse the repository at this point in the history

  2. Update tests

    @Myranae
    Myranae committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    a46486c View commit details
    Browse the repository at this point in the history

  3. Add changeset

    @Myranae
    Myranae committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    a9351e9 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Confirm scoring handles validation responses

    @Myranae
    Myranae committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    e602bfa View commit details
    Browse the repository at this point in the history

  2. Remove rubric from validation as its not needed

    @Myranae
    Myranae committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    9e8c6c7 View commit details
    Browse the repository at this point in the history

  3. Update with expected input

    @Myranae
    Myranae committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    0837d70 View commit details
    Browse the repository at this point in the history

  4. Rearrange test for PR clarity

    @Myranae
    Myranae committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    71e4a6f View commit details
    Browse the repository at this point in the history

  5. Update value 

    Unnecessary value since the validator is being mocked, but want to keep it consistent
    @Myranae
    Myranae committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    7fe7859 View commit details
    Browse the repository at this point in the history

  6. Keep vocab consistent

    @Myranae
    Myranae committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    9a323dd View commit details
    Browse the repository at this point in the history

  7. Add arrange, act, assert comments

    @Myranae
    Myranae committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    5327ece View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Add validation function doc comment

    @Myranae
    Myranae committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    61de24e View commit details
    Browse the repository at this point in the history